Remove play-json from dependencies #82
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Co-authored-by: @alinaboghiu @rtyley
What does this change?
In the past week, we experienced issues with mobile notifications not being sent out. Logs were indicating
void play.api.libs.json.Format.$init$(play.api.libs.json.Format)errors since upgrading themobile-notifications-api-modelslibrary from1.0.16to1.0.18.@rtyley helpfully pointed out this was due to a conflict in the version of the
play-jsonlibrary that this project is using vs. the versionmobile-notifications-api-modelslibrary is using. Normally scala would default to using the latest version of the library in case of such conflict but the because the author of this library has changed (com.typesafe.play→org.playframework), it resulted in the conflict.This PR therefore removes the play-json from the project dependencies as we can import the correct version via the
mobile-notifications-api-modelslibrary.How to test
I tested this on CODE by creating a test article on composer CODE. The logs look healthy
Lambda logs
Notification api logs
