don't error an unsupported plan for staff membership #1091
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rupertbates
approved these changes
Jul 30, 2024
|
Seen on PROD (merged by @johnduffell 5 minutes and 20 seconds ago) Please check your changes! Sentry Release: members-data-api |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Back in this PR: #1072
i removed staff membership recognition from the whole of MDAPI.
However all the staff subscriptions in zuora still exist (for now - they need cancelling really)
However, there is a bit of logic that logs if a rate plan's product isn't in the catalog mappings that are in the code.
Since I deleted the mapping for staff, every time a staff member hits /me endpoint, we get an error logged:
2024-07-30 08:47:09,031 SupporterRatePlanToAttributesMapper.scala:37 [ERROR]: redacted: Unsupported product rate plan id: 2c92a0f949efde7c0149f1f18162178eThis PR specifically doesn't log this exact sitatuion, purely to clean up the logs.