Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Expanded the error message that is shown to the user when their account ... #26

Merged
merged 1 commit into from
Jul 4, 2014
Merged

Expanded the error message that is shown to the user when their account ... #26

merged 1 commit into from
Jul 4, 2014

Conversation

snim2
Copy link
Contributor

@snim2 snim2 commented Jul 3, 2014

...is private or < 3 months old.

Note: not yet tested.

@snim2
Expanded the error message that is shown to the user when their accou…
1d5e654 
…nt is private or < 3 months old.

Note: not yet tested.
@gidsg
Copy link

gidsg commented Jul 4, 2014

Hey @snim2 thanks for this suggestion! I would rather we link directly to the members page (i.e. /orgs/$org/members rather than describing a UI which is likely to change.
CC @rtyley

@snim2
Copy link
Contributor Author

snim2 commented Jul 4, 2014

Hi @gidsg that sound perfectly sensible to me! Giving the user a clear action to take is the main thing.

@rtyley rtyley merged commit 1d5e654 into guardian:master Jul 4, 2014
@rtyley
Copy link
Member

rtyley commented Jul 4, 2014

I added @gidsg suggestion with 51f492e, and merged to master. I've also sent a request to the GitHub folks asking them to improve the public/private membership documentation and UI...

@rtyley rtyley mentioned this pull request Aug 28, 2014
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Seen-on-PROD
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@snim2 @gidsg @rtyley @prout-bot