-
Notifications
You must be signed in to change notification settings - Fork 555
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update npm and ruby dependencies #5393
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
👍 |
That's one detailed PR |
…endencies Conflicts: common/app/assets/images/global/arrow-white-right.svg common/app/assets/images/global/back.svg common/app/assets/images/global/close-icon.svg common/app/assets/images/global/guardian-logo-big.svg
This reverts commit 8edd90f.
This reverts commit b4e3992.
This reverts commit 78e3b27. Conflicts: common/app/assets/images/global/arrow-white-right.svg common/app/assets/images/global/back.svg common/app/assets/images/global/close-icon.svg common/app/assets/images/global/guardian-logo-big.svg
I have reverted the npm dependency update. SVGO was unpredictable, generating a new (larger) SVG at each compilation. Kept only Ruby updates. |
kaelig
added a commit
that referenced
this pull request
Aug 6, 2014
Update npm and ruby dependencies
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Optimise SVGs with latest version of SVGO(SVGO 0.4.5 seems unpredictable)&
nested selectors)Update Sass from 3.3.7 to 3.3.14
3.3.14 (1 August 2014)
calc()
andexpression()
.--update
with absolute paths on Windows.3.3.13 (31 July 2014)
Work around for a bug in listen.
3.3.12 (29 July 2014)
Compass's compilation needs:
side-effect events.
that runs before stylesheets are mass-updated.
that runs before an individual stylesheet is compiled.
after stylesheets are mass-updated.
when watching.
3.3.11 (25 July 2014)
str-slice()
now correctly returns an empty string when$end-at
is 0.3.3.10 (11 July 2014)
3.3.9 (27 June 2014)
definition-time. This isn't considered a backwards-incompatible change because
although these functions could be defined previously, they could never be
successfully invoked.
File.exists?
on recent Ruby versions.@extend
within@at-root
could crash the compiler.3.3.8 (20 May 2014)
@at-root
doesn't add any new rules, it will no longer splitits containing block in two (issue 1239).
sass-convert
bug where rules would occasionally be folded togetherincorrectly when converting from CSS to Sass.
@media
queries with emptyqueries.
Update SVGO from 0.4.4 to 0.4.5Version 0.4.5 of SVGO was generating new files at every optimisation. Meaning at every sprite generation there would have been a new SVG file (also: somewhat badly optimised).