Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use rendering baseURL for /EmailNewsletters #26877

Merged
merged 1 commit into from
Feb 6, 2024

Conversation

cemms1
Copy link
Contributor

@cemms1 cemms1 commented Feb 6, 2024

What is the value of this and can you measure success?

After an attempt to find the route cause of the issue in #26873, we're still seeing errors and alerts coming through on the facia app.

What does this change?

This PR reverts to using the previous base URL (for the rendering app instead of the facia-rendering app) to help debug why this is happening

@cemms1 cemms1 marked this pull request as ready for review February 6, 2024 10:10
@cemms1 cemms1 requested a review from a team as a code owner February 6, 2024 10:10
Copy link
Contributor

@DanielCliftonGuardian DanielCliftonGuardian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@cemms1 cemms1 merged commit f8f248e into main Feb 6, 2024
2 checks passed
@cemms1 cemms1 deleted the cemms1/swap-dcr-endpoint-for-emailnewsletters branch February 6, 2024 10:27
@prout-bot
Copy link
Collaborator

Seen on FRONTS-PROD, ADMIN-PROD (merged by @cemms1 11 minutes and 9 seconds ago)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants