Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Send interactives DCR traffic to new interactive-rendering app #26866

Merged
merged 1 commit into from
Feb 5, 2024

Conversation

cemms1
Copy link
Contributor

@cemms1 cemms1 commented Feb 1, 2024

What is the value of this and can you measure success?

Continues work to split out the DCR apps by sending DCR traffic for interactives to the new interactive-rendering app

Resolves guardian/dotcom-rendering#9324

What does this change?

  • Adds new config value for the interactive-rendering app base URL
  • Swaps the general rendering baseURL for the interactive one for interactives requests
  • Additionally swaps the rendering baseURL for /EmailNewsletters to go to the facia-rendering app instead as this is the most appropriate of the three apps to send this request to

@cemms1 cemms1 marked this pull request as ready for review February 1, 2024 17:42
@cemms1 cemms1 requested a review from a team as a code owner February 1, 2024 17:42
Copy link
Contributor

@mxdvl mxdvl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cemms1 cemms1 merged commit 847429d into main Feb 5, 2024
2 checks passed
@cemms1 cemms1 deleted the cemms1/use-interactives-rendering-app branch February 5, 2024 10:10
@prout-bot
Copy link
Collaborator

Seen on FRONTS-PROD (merged by @cemms1 12 minutes and 22 seconds ago)

@prout-bot
Copy link
Collaborator

Seen on ADMIN-PROD (merged by @cemms1 12 minutes and 29 seconds ago)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create Interactives DCR App
3 participants