⛔️ [DO NOT MERGE] ⛔️ feat: use FrontRemoteRenderer behind a switch #26556
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
"This PR is stale because it has been open 30 days with no activity. Unless a comment is added or the “stale” label removed, this will be closed in 3 days" |
|
This PR was closed because it has been stalled for 3 days with no activity. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the value of this and can you measure success?
This allows us to use our new fancy Fronts rendering stack!
TL;DR; is that this removes the single point of failure with the current architecture, you can read more about that here and see the DCR part here.
This is a test, and ideally
DotcomRenderingServiceshould probably have thebaseUrlas a non-optional string, but this feels like a nice first step.Hopefully we will be able to spin up the guessed-required amount of instances in DCR and up the test to monitor if we need to add more, or scale down.
Co-authored-by: Georges Lebreton [email protected]