Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix old sonatypeRepo config #25803

Merged
merged 1 commit into from
Jan 3, 2023
Merged

Fix old sonatypeRepo config #25803

merged 1 commit into from
Jan 3, 2023

Conversation

rtyley
Copy link
Member

@rtyley rtyley commented Dec 21, 2022

In February 2021 Sonatype started spreading its OSS Maven artifact hosting across 2 repository hosts, so we need to use the plural sonatypeOssRepos (introduced with sbt/librarymanagement#393) rather than the deprecated singular sonatypeRepo. Otherwise we get this warning in the build:

Use sonatypeOssRepos instead e.g. `resolvers ++= Resolver.sonatypeOssRepos("snapshots")`

I managed to miss this when I was doing #25781, tho' I caught it elsewhere (#25781 (comment))!

I making this change partly just to see if Prout reports the merge correctly.

In February 2021 Sonatype started spreading its OSS Maven artifact
hosting across 2 repository hosts, so we need to use the plural
`sonatypeOssRepos` (introduced with sbt/librarymanagement#393)
rather than the deprecated singular `sonatypeRepo`.

https://central.sonatype.org/news/20210223_new-users-on-s01/

I managed to miss this when I was doing #25781,
tho' I caught it elsewhere! #25781 (comment)
@rtyley rtyley requested a review from a team as a code owner December 21, 2022 09:56
@rtyley rtyley changed the title Fix old sonatypeRepo config Fix old sonatypeRepo config Dec 21, 2022
Copy link
Contributor

@DanielCliftonGuardian DanielCliftonGuardian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✓ looks good

@prout-bot
Copy link
Collaborator

Seen on FRONTS-PROD, ADMIN-PROD (merged by @rtyley 6 hours, 56 minutes and 43 seconds ago)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants