Update CAPI & FAPI clients to latest versions (also remove hack required for Lightbox)

[ioannakok]

What does this change?

The latest version of the CAPI client (v19) includes guardian/content-api-scala-client#359, which we can use to replace the pagination code based on play-iteratees (introduced in July 2014 with #5199), currently blocking the Scala 2.13 upgrade for Frontend.

The updated CAPI client is binary-incompatible with previous versions of the CAPI client, meaning we also need to update the FAPI client - as it also uses CAPI, and needs to be compiled against the same CAPI version. A similar PR, updating FAPI & CAPI in Ophan is at https://github.com/guardian/ophan/pull/4719, and has been successfully deployed. Like there, we're adding a FaciaClientTest that will break at build time rather than runtime if our versions of the FAPI & CAPI clients are incompatible.

The updates to the CAPI client also support previous/next search functionality, as used by the Lightbox, meaning that the small ContentApiNavQuery hack for the Lightbox (introduced here: #20462) can now be removed.

Screenshots

The next/previous functionality in lightboxes (eg on this article) from #20462 continues to work:

Screen.Recording.2022-06-30.at.11.48.37.mov

Checklist

Does this change update the version of CAPI we're using?

• No, all the existing database files are just fine
• Yes, and I have re-run all the tests locally and checked in all the updated data/database/xyz files

Tested

• Locally
• On CODE (optional)

[ioannakok]

Deployment to CODE succeeded almost everywhere except for facia-press. We should release a beta version of facia-client: https://logs.gutools.co.uk/s/dotcom/goto/02ce2d00-f24e-11ec-9ed0-71515ea686c5

[ioannakok]

We compared and they were the same:

https://m.code.dev-theguardian.com/getprev/commentisfree/series/guardian-comment-cartoon/commentisfree/picture/2022/may/22/brian-adcock-on-the-looming-sue-gray-report-cartoon

https://theguardian.com/getprev/commentisfree/series/guardian-comment-cartoon/commentisfree/picture/2022/may/22/brian-adcock-on-the-looming-sue-gray-report-cartoon

[rtyley]

I've rolled back the Frontend CODE environment to main - the deploy went fine.

On our branch, without updating facia-scala-client (ie without using a facia-scala-client release incorporating guardian/facia-scala-client#271), we see this java.lang.NoSuchMethodError exception on facia-press for com.gu.contentapi.client.Decoder$.searchQueryBase():

java.lang.NoSuchMethodError: 'com.gu.contentapi.client.Decoder com.gu.contentapi.client.Decoder$.searchQueryBase()'
	at com.gu.facia.api.contentapi.ContentApi$.$anonfun$getHydrateResponse$1(ContentApi.scala:37)
	at scala.concurrent.Future$.$anonfun$traverse$1(Future.scala:850)
	at scala.collection.LinearSeqOptimized.foldLeft(LinearSeqOptimized.scala:126)
	at scala.collection.LinearSeqOptimized.foldLeft$(LinearSeqOptimized.scala:122)
	at scala.collection.immutable.List.foldLeft(List.scala:91)
	at scala.concurrent.Future$.traverse(Future.scala:850)
	at com.gu.facia.api.contentapi.ContentApi$.getHydrateResponse(ContentApi.scala:37)
	at com.gu.facia.api.FAPI$.$anonfun$getLiveContentForCollection$1(FAPI.scala:75)
	at com.gu.facia.api.Response.$anonfun$flatMap$1(Response.scala:13)
	at scala.concurrent.Future.$anonfun$flatMap$1(Future.scala:307)
	at scala.concurrent.impl.Promise.$anonfun$transformWith$1(Promise.scala:41)
	at scala.concurrent.impl.CallbackRunnable.run(Promise.scala:64)
	at akka.dispatch.BatchingExecutor$AbstractBatch.processBatch(BatchingExecutor.scala:63)
	at akka.dispatch.BatchingExecutor$BlockableBatch.$anonfun$run$1(BatchingExecutor.scala:100)
	at scala.runtime.java8.JFunction0$mcV$sp.apply(JFunction0$mcV$sp.java:23)
	at scala.concurrent.BlockContext$.withBlockContext(BlockContext.scala:85)
	at akka.dispatch.BatchingExecutor$BlockableBatch.run(BatchingExecutor.scala:100)
	at akka.dispatch.TaskInvocation.run(AbstractDispatcher.scala:49)
	at akka.dispatch.ForkJoinExecutorConfigurator$AkkaForkJoinTask.exec(ForkJoinExecutorConfigurator.scala:48)
	at java.base/java.util.concurrent.ForkJoinTask.doExec(ForkJoinTask.java:290)
	at java.base/java.util.concurrent.ForkJoinPool$WorkQueue.topLevelExec(ForkJoinPool.java:1020)
	at java.base/java.util.concurrent.ForkJoinPool.scan(ForkJoinPool.java:1656)
	at java.base/java.util.concurrent.ForkJoinPool.runWorker(ForkJoinPool.java:1594)
	at java.base/java.util.concurrent.ForkJoinWorkerThread.run(ForkJoinWorkerThread.java:183)

This is the code in facia-scala-client:

Future.traverse(searchQueries)(client.getResponse(_))

[rtyley]

Deploying build 43804 (71b241d - which has the FAPI client updated to use the same CAPI client with guardian/facia-scala-client#271) to CODE has completed - happily, there are no further java.lang.NoSuchMethodError errors showing up in the logs:

The lightbox functionality from #20462 is also working:

Screen.Recording.2022-06-30.at.11.48.37.mov

[jfsoul]

💯

[prout-bot]

Seen on PROD (merged by @ioannakok 18 minutes and 23 seconds ago)

• Check your changes on www.theguardian.com ✔️
• Keep an eye on the deploy dashboard 📉

[rtyley]

Deployed on PROD, and the lightbox still works!

Screen.Recording.2022-07-01.at.16.39.39.mov