Render Showcase formatted feeds for pressed fronts #24038
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tonytw1
changed the title
tonytw1
changed the title
tonytw1
force-pushed
the
showcase-rss
branch
2 times, most recently
from
eebab9b to
f1465f4
Compare
tonytw1
commented
Aug 27, 2021
tonytw1
commented
Aug 27, 2021
tonytw1
commented
Aug 27, 2021
tonytw1
force-pushed
the
showcase-rss
branch
3 times, most recently
from
8273256 to
c57d6ae
Compare
added 17 commits
September 2, 2021 10:37
…case modules while still using Rome as the framework.
This is almost certainly not what we what but shows we can get through the frontend ingress.
…e which contains Collections and Cards from the Fronts editor. Pivot to /showcase end point in facia. Begin sourcing Showcase fields from the PressedContent model rather than Trails. Provide a rough fixture for creating test PressedContent. Unroll changes to TrailsRSS which are no longer of interest to us.
… best place to pickup panel images from a Card.
…e to populate Showcase update fields. Last updated is a mandatory field in Showcase so we should be attempting to populate with good data.
…which cannot be made valid from the give content item.
added 10 commits
September 2, 2021 16:44
We will need to adjust Rome's default behaviour to match this.
davidfurey
reviewed
Sep 3, 2021
| @@ -0,0 +1,2 @@ | |||
| rss_1.0.item.ModuleGenerator.classes=common.GModuleGenerator,common.RssAtomModuleGenerator | |||
There was a problem hiding this comment.
Does this need to be added to dev-build and preview too?
There was a problem hiding this comment.
Oddly it does not appear to be needed; the classpath is probably leaking across into dev build and preview.
Preview might need to be revisited in a real environment but we well probably be doing something visual rather than rendering RSS in real preview. So not a blocker/
| rss.getNamespace("media") should be("http://search.yahoo.com/mrss/") | ||
| } | ||
|
|
||
| "TrailsToShowcase" can "render feed with Single Story and Rundown panels" in { |
There was a problem hiding this comment.
This test seems to be covering a lot of things, would it make sense to break it up?
There was a problem hiding this comment.
I'll ok with this; this test is acting an 'yeah but does it actually render' integration test and I'm fining it useful in this form.
| @@ -35,6 +35,7 @@ GET /most-relevant-container/*path.json | |||
| GET /*path/show-more/*id.json controllers.FaciaController.renderShowMore(path, id) | |||
| GET /rss controllers.FaciaController.renderRootFrontRss() | |||
| GET /*path/rss controllers.FaciaController.renderFrontRss(path) | |||
| GET /*path/showcase controllers.FaciaController.renderFrontShowcase(path) | |||
There was a problem hiding this comment.
This might also need to be added to dev-build routes
There was a problem hiding this comment.
Done in preview and dev-build.
added 9 commits
September 3, 2021 12:59
…inclusion in the author tag rather than dc:creator Showcase's usage of the author tag is slightly off spec here.
We will almost certainly end up trying to override this with some visual.
…operties.maybeContent.metadata.webUrl Which is a full url rather than a URI.
…ain objects. Rather than Rome feed clases; sets up for preview of panels.
davidfurey
approved these changes
Sep 7, 2021
|
Seen on PROD (merged by @tonytw1 18 minutes and 31 seconds ago)
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Render Showcase formatted feeds on a
/showcasesuffix for pressed fronts.Showcase is an extension of RSS.
We use a Rome RSS module to render the new
gandatomfields.Adds a new lastModified optional field to PressedCards.
Fronts tool collections are used to populate Single Story and Rundown Panels.
Each Showcase feed will have it's own front in the showcase priority in the Fronts tool.
Only fronts which have the magic
StandaloneandRundowncontainers will render is Showcase feeds.What does this change?
Does this change need to be reproduced in dotcom-rendering ?
Screenshots
What is the value of this and can you measure success?
Can pass a live guardian showcase feed url to Showcase feed validator and have it pass.
Checklist
Does this affect other platforms?
Does this affect GLabs Paid Content Pages? Should it have support for Paid Content?
Does this change break ad-free?
Does this change update the version of CAPI we're using?
Accessibility test checklist
Tested