Remove s3 WSClient. Replace with S3 API #18359
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
QuarpT
requested review from
TBonnin,
MatthewJWalls,
rich-nguyen and
johnduffell
QuarpT
commented
Nov 28, 2017
| import scala.concurrent.{ExecutionContext, Future} | ||
|
|
||
| trait FrontJsonFapi extends Logging { | ||
| lazy val stage: String = Configuration.facia.stage.toUpperCase | ||
| val bucketLocation: String | ||
| val parallelJsonPresses = 16 |
There was a problem hiding this comment.
Increasing to 16 after seeing sporadic exceptions in prod with a low threshold of 8.
|
PRbuilds results: Screenshots 💚 Exceptions 💚 A11y validation Apache Benchmark Load Testing 💚 Microdata Validation --automated message |
TBonnin
suggested changes
Nov 30, 2017
| pressedPageFromS3(getAddressForPath(path, "json")) | ||
| } | ||
|
|
||
| private def pressedPageFromS3(path: String)(implicit executionContext: ExecutionContext): Future[Option[PressedPage]] = errorLoggingF(s"FrontJsonFapi.pressedPageFromS3 $path") { |
There was a problem hiding this comment.
Is this private methode necessary? Can its content be moved into get above?
| log.warn("Could not parse JSON in FrontJson") | ||
| None | ||
| } | ||
| FaciaPressMetrics.FrontDecodingLatency.recordDuration(stopWatch.elapsed) |
There was a problem hiding this comment.
Can we keep this metric recording?
TBonnin
approved these changes
Nov 30, 2017
|
Seen on PROD (merged by @QuarpT 25 minutes and 7 seconds ago)
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this change?
Removes the custom S3 WSClient - it's only used in one place and seems unnecessary. The difference is that WSClient is non-blocking - so I've wrapped the amazon API in blocking operations thread pool.
If we want to avoid using the native Java Amazon API, then we should use https://developer.lightbend.com/docs/alpakka/current/s3.html rather than implement our own http client.
What is the value of this and can you measure success?
Simplifies retrieving facia fronts
Tested in CODE?
I will