Upgrade react native #288
Upgrade react native #288
Conversation
|
can we make sure there are no regressions on the animation from front to article? Namely the article should be cropped on the top and bottom sides as it opens and dragging it down should make it fit back into its card |
| @@ -26,8 +21,6 @@ - (BOOL)application:(UIApplication *)application didFinishLaunchingWithOptions:( | |||
| RCTRootView *rootView = [[RCTRootView alloc] initWithBridge:bridge | |||
| moduleName:@"Mallard" | |||
| initialProperties:nil]; | |||
| [RNSentry installWithRootView:rootView]; | |||
There was a problem hiding this comment.
Should this have come out?
| @@ -62,8 +62,6 @@ | |||
| </dict> | |||
| </dict> | |||
| </dict> | |||
| <key>NSLocationWhenInUseUsageDescription</key> | |||
There was a problem hiding this comment.
Can we double check this?
There was a problem hiding this comment.
facebook/react-native#20879
No longer bundled in rn.
| "react-navigation": "3.11.0", | ||
| "react-native-status-bar-height": "^2.4.0", | ||
| "react-native-svg": "^9.6.2", | ||
| "react-native-webview": "^6.9.0", |
There was a problem hiding this comment.
Can we find the breaking changes for this? Webview's are a bit shakey at the best of times!
There was a problem hiding this comment.
The changelog isn't particularly readable, but it doesn't seem to have any breaking changes.
…?from=0.59.3&to=0.60.0 package updates Unlink everything add pods This was causing a problem so is gone. This was causing a problem so I removed it. Install pods fix typo upgrades? More upgrades yarn lock unlink pods fix config weirdness facebook/react-native#25484 zo0r/react-native-push-notification#1147 zo0r/react-native-push-notification#1147 note on cache cleaning remove crossword bunder from main shell gradle.properties change needed in https://react-native-community.github.io/upgrade-helper/?from=0.59.3&to=0.60.4 not sure about keystor fix build.gradle to .60 achetype fix build.gradle force use of correct rn types
|
I'm having trouble building the preupgrade version on android. (With everything cleaned and on master) |
I've had to upgrade and unlink everything and install cocoapods.