Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: IAP Migration Message #2512

Merged
merged 4 commits into from
Oct 24, 2024
Merged

feat: IAP Migration Message #2512

merged 4 commits into from
Oct 24, 2024

Conversation

jimhunty
Copy link
Contributor

Why are you doing this?

Adds a message to In App Purchase users about the app migration

Changes

  • Adds a new modal route
  • New Copy
  • Looks to reuse the modal cards, and follows their approach, but need to implement different styling
  • Once dismissed, this is persisted so it doesnt show again
  • Dev menu button to clear persistence for testing.

Screenshots

Simulator Screenshot - iPhone 15 Pro - 2024-10-24 at 07 52 25

@jimhunty jimhunty requested a review from a team as a code owner October 24, 2024 07:15
groakland
groakland approved these changes Oct 24, 2024
View reviewed changes
Copy link
Contributor

@groakland groakland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jimhunty jimhunty merged commit b5368eb into main Oct 24, 2024
8 checks passed
@jimhunty jimhunty deleted the feat/iap-migration-message branch October 24, 2024 08:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@groakland groakland groakland approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jimhunty @groakland