Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Snyk kill-port #2493

Merged
merged 1 commit into from
Sep 3, 2024
Merged

fix: Snyk kill-port #2493

merged 1 commit into from
Sep 3, 2024

Conversation

jimhunty
Copy link
Contributor

@jimhunty jimhunty commented Sep 2, 2024

Why are you doing this?

Snyk job is currently failing on main: https://github.com/guardian/editions/actions/runs/10662023825/job/29548498279

This looks to resolve it.

Changes

  • Remove the duplicate import of kill-port from crosswords

Outputs

Can confirm it works: https://github.com/guardian/editions/actions/runs/10662738956

Has no effect on showing crosswords in dev.

simulator_screenshot_A00731E9-AFB0-4791-AB82-D0C965B5CDE5

@jimhunty jimhunty requested a review from a team as a code owner September 2, 2024 07:31
groakland
groakland approved these changes Sep 3, 2024
View reviewed changes
Copy link
Contributor

@groakland groakland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jimhunty jimhunty merged commit df9730e into main Sep 3, 2024
9 checks passed
@jimhunty jimhunty deleted the fix/snyk-kill-port branch September 3, 2024 07:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@groakland groakland groakland approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jimhunty @groakland