Skip to content
This repository has been archived by the owner on Jan 6, 2025. It is now read-only.

fix: Crossword Sign In Crash #2270

Merged
merged 1 commit into from
Sep 5, 2023
Merged

fix: Crossword Sign In Crash #2270

merged 1 commit into from
Sep 5, 2023

Conversation

jimhunty
Copy link
Contributor

@jimhunty jimhunty commented Sep 5, 2023

Why are you doing this?

Fix the break when a user tries to sign in via the crosswords

Changes

  • Instead of taking the user back to the Article when they choose to sign in, we take them back to the issue screen. Does mean once they log in, they will need to find the article they want to read again, but the front should be in the same place.

Screenshots

2023-09-05 09 56 04

@jimhunty jimhunty requested a review from a team September 5, 2023 09:04
groakland
groakland approved these changes Sep 5, 2023
View reviewed changes
Copy link
Contributor

@groakland groakland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@groakland groakland merged commit 503e782 into master Sep 5, 2023
@groakland groakland deleted the fix/crossword-signin-crash branch September 5, 2023 10:48
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@groakland groakland groakland approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jimhunty @groakland