Add new article stack using GuEc2App pattern for dual stack migration #9955

cemms1 · 2023-12-19T14:07:57Z

Note

This PR is an updated version of #9389

What does this change?

Adds a new CDK stack, using the GuEc2App pattern. This has the bonus of allowing us to use an ALB rather than an ELB. It also reduces the amount of code the WebX team have to write and maintain for our infrastructure provisioning.

As part of adding the new stack, we've adapted our naming strategy and opted for prefixing the words app and stack with gu or cdk where appropriate, since the concept of these things means totally different things in the Guardian or AWS contexts.

This work is part of a larger piece of work aiming to split DCR into a number of separate rendering applications to manage the scaling of our application in a better way.

We are considering having the following apps:

article (includes all articles except interactive articles)
facia (includes front pages and tag pages)
interactives (handles the interactive articles separated from the article app)
misc (other DCR-supported pages that aren't articles, front pages, or tag pages e.g. the all newsletters page)

This PR:

adds a new article-rendering app (in cdk/lib/renderingStack.ts and cdk/bin/cdk.ts)
- this app uses the ec2App GuCDK pattern
adds a new riff-raff deployment for this app (and for subsequent apps ie. facia, interactives, misc) in scripts/deploy/riff-raff-v2.yaml
- this new riff-raff deployment is available under the project name dotcom:rendering-all as opposed to the existing deployment of dotcom:rendering, since this matches the frontend naming style
does not change the existing app deployment, apart from removing the front-web app since this was not used
- this allows us to do a dual stack migration and deploy both versions of the apps at the same time, and simply switch from one to the other using a PR like Use new base URL for DCR article endpoints frontend#26789

Why?

Resolves #9374 and will resolve #9310

Co-authored by: @JamieB-gu
Co-authored by: @abeddow91

github-actions · 2023-12-19T14:13:44Z

Size Change: 0 B

Total Size: 741 kB

ℹ️ View Unchanged

Filename	Size
`dotcom-rendering/dist/1028.web.********************.js`	783 B
`dotcom-rendering/dist/1079.web.********************.js`	5.05 kB
`dotcom-rendering/dist/11.web.********************.js`	5.18 kB
`dotcom-rendering/dist/115.web.********************.js`	3.68 kB
`dotcom-rendering/dist/1170.web.********************.js`	3.6 kB
`dotcom-rendering/dist/1285.web.********************.js`	921 B
`dotcom-rendering/dist/1309.web.********************.js`	637 B
`dotcom-rendering/dist/1378.web.********************.js`	503 B
`dotcom-rendering/dist/1623.web.********************.js`	847 B
`dotcom-rendering/dist/2027.web.********************.js`	3.08 kB
`dotcom-rendering/dist/2030.web.********************.js`	491 B
`dotcom-rendering/dist/2118.web.********************.js`	775 B
`dotcom-rendering/dist/2138.web.********************.js`	2.59 kB
`dotcom-rendering/dist/2416.web.********************.js`	775 B
`dotcom-rendering/dist/2710.web.********************.js`	999 B
`dotcom-rendering/dist/2903.web.********************.js`	884 B
`dotcom-rendering/dist/2993.web.********************.js`	636 B
`dotcom-rendering/dist/3032.web.********************.js`	3.15 kB
`dotcom-rendering/dist/307.web.********************.js`	13.2 kB
`dotcom-rendering/dist/3316.web.********************.js`	3.48 kB
`dotcom-rendering/dist/3664.web.********************.js`	5.5 kB
`dotcom-rendering/dist/3743.web.********************.js`	900 B
`dotcom-rendering/dist/3849.web.********************.js`	3.33 kB
`dotcom-rendering/dist/3958.web.********************.js`	39.9 kB
`dotcom-rendering/dist/3999.web.********************.js`	744 B
`dotcom-rendering/dist/408.web.********************.js`	3.38 kB
`dotcom-rendering/dist/4215.web.********************.js`	404 B
`dotcom-rendering/dist/4298.web.********************.js`	8.12 kB
`dotcom-rendering/dist/4355.web.********************.js`	710 B
`dotcom-rendering/dist/4464.web.********************.js`	3.79 kB
`dotcom-rendering/dist/4567.web.********************.js`	819 B
`dotcom-rendering/dist/4578.web.********************.js`	3.5 kB
`dotcom-rendering/dist/4698.web.********************.js`	2.47 kB
`dotcom-rendering/dist/4946.web.********************.js`	718 B
`dotcom-rendering/dist/4950.web.********************.js`	664 B
`dotcom-rendering/dist/512.web.********************.js`	819 B
`dotcom-rendering/dist/5165.web.********************.js`	742 B
`dotcom-rendering/dist/5242.web.********************.js`	524 B
`dotcom-rendering/dist/533.web.********************.js`	916 B
`dotcom-rendering/dist/5481.web.********************.js`	5.2 kB
`dotcom-rendering/dist/5840.web.********************.js`	915 B
`dotcom-rendering/dist/5927.web.********************.js`	819 B
`dotcom-rendering/dist/5996.web.********************.js`	797 B
`dotcom-rendering/dist/6388.web.********************.js`	5.75 kB
`dotcom-rendering/dist/651.web.********************.js`	847 B
`dotcom-rendering/dist/6541.web.********************.js`	909 B
`dotcom-rendering/dist/6643.web.********************.js`	950 B
`dotcom-rendering/dist/6756.web.********************.js`	519 B
`dotcom-rendering/dist/6763.web.********************.js`	589 B
`dotcom-rendering/dist/6784.web.********************.js`	739 B
`dotcom-rendering/dist/6802.web.********************.js`	990 B
`dotcom-rendering/dist/7002.web.********************.js`	871 B
`dotcom-rendering/dist/7179.web.********************.js`	2.51 kB
`dotcom-rendering/dist/7444.web.********************.js`	781 B
`dotcom-rendering/dist/7496.web.********************.js`	6.39 kB
`dotcom-rendering/dist/7666.web.********************.js`	2.75 kB
`dotcom-rendering/dist/7726.web.********************.js`	955 B
`dotcom-rendering/dist/7860.web.********************.js`	675 B
`dotcom-rendering/dist/7880.web.********************.js`	9.97 kB
`dotcom-rendering/dist/8003.web.********************.js`	2.85 kB
`dotcom-rendering/dist/8060.web.********************.js`	578 B
`dotcom-rendering/dist/8288.web.********************.js`	23 kB
`dotcom-rendering/dist/8320.web.********************.js`	796 B
`dotcom-rendering/dist/8388.web.********************.js`	612 B
`dotcom-rendering/dist/8442.web.********************.js`	3.79 kB
`dotcom-rendering/dist/8562.web.********************.js`	998 B
`dotcom-rendering/dist/8795.web.********************.js`	16.2 kB
`dotcom-rendering/dist/8860.web.********************.js`	2.49 kB
`dotcom-rendering/dist/8995.web.********************.js`	782 B
`dotcom-rendering/dist/9031.web.********************.js`	8.92 kB
`dotcom-rendering/dist/9033.web.********************.js`	883 B
`dotcom-rendering/dist/9045.web.********************.js`	715 B
`dotcom-rendering/dist/9106.web.********************.js`	2.97 kB
`dotcom-rendering/dist/9145.web.********************.js`	4.23 kB
`dotcom-rendering/dist/9206.web.********************.js`	4.71 kB
`dotcom-rendering/dist/9458.web.********************.js`	5.1 kB
`dotcom-rendering/dist/9479.web.********************.js`	2.91 kB
`dotcom-rendering/dist/9591.web.********************.js`	1.84 kB
`dotcom-rendering/dist/9721.web.********************.js`	646 B
`dotcom-rendering/dist/9856.web.********************.js`	5.75 kB
`dotcom-rendering/dist/9893.web.********************.js`	3.26 kB
`dotcom-rendering/dist/9895.web.********************.js`	5.04 kB
`dotcom-rendering/dist/991.web.********************.js`	3.15 kB
`dotcom-rendering/dist/AdPortals-importable.web.********************.js`	3.65 kB
`dotcom-rendering/dist/AlreadyVisited-importable.web.********************.js`	415 B
`dotcom-rendering/dist/AppEmailSignUp-importable.web.********************.js`	8.16 kB
`dotcom-rendering/dist/AppsEpic-importable.web.********************.js`	4.02 kB
`dotcom-rendering/dist/AppsFooter-importable.web.********************.js`	3.57 kB
`dotcom-rendering/dist/AppsLightboxImage-importable.web.********************.js`	2.96 kB
`dotcom-rendering/dist/AppsLightboxImageStore-importable.web.********************.js`	2.42 kB
`dotcom-rendering/dist/AudioAtomWrapper-importable.web.********************.js`	3.58 kB
`dotcom-rendering/dist/AustralianTerritorySwitcher-importable.web.********************.js`	4.61 kB
`dotcom-rendering/dist/Branding-importable.web.********************.js`	2.52 kB
`dotcom-rendering/dist/braze-web-sdk-core.web.********************.js`	36.9 kB
`dotcom-rendering/dist/BrazeMessaging-importable.web.********************.js`	5.26 kB
`dotcom-rendering/dist/CalloutBlockComponent-importable.web.********************.js`	6.78 kB
`dotcom-rendering/dist/CalloutEmbedBlockComponent-importable.web.********************.js`	5.77 kB
`dotcom-rendering/dist/CardCommentCount-importable.web.********************.js`	4.39 kB
`dotcom-rendering/dist/Carousel-importable.web.********************.js`	7.78 kB
`dotcom-rendering/dist/CarouselForNewsletters-importable.web.********************.js`	5.66 kB
`dotcom-rendering/dist/ChartAtom-importable.web.********************.js`	537 B
`dotcom-rendering/dist/CommentCount-importable.web.********************.js`	3.21 kB
`dotcom-rendering/dist/DiscussionContainer-importable.web.********************.js`	23.4 kB
`dotcom-rendering/dist/DiscussionMeta-importable.web.********************.js`	3.74 kB
`dotcom-rendering/dist/DocumentBlockComponent-importable.web.********************.js`	3.57 kB
`dotcom-rendering/dist/EmbedBlockComponent-importable.web.********************.js`	4.1 kB
`dotcom-rendering/dist/EnhancePinnedPost-importable.web.********************.js`	1.96 kB
`dotcom-rendering/dist/FetchOnwardsData-importable.web.********************.js`	2.51 kB
`dotcom-rendering/dist/FilterKeyEventsToggle-importable.web.********************.js`	3.32 kB
`dotcom-rendering/dist/FocusStyles-importable.web.********************.js`	608 B
`dotcom-rendering/dist/FollowWrapper-importable.web.********************.js`	3.08 kB
`dotcom-rendering/dist/FooterLabel-importable.web.********************.js`	336 B
`dotcom-rendering/dist/frameworks.web.********************.js`	20.7 kB
`dotcom-rendering/dist/GetCricketScoreboard-importable.web.********************.js`	3.72 kB
`dotcom-rendering/dist/GetMatchNav-importable.web.********************.js`	9.64 kB
`dotcom-rendering/dist/GetMatchStats-importable.web.********************.js`	1.74 kB
`dotcom-rendering/dist/GetMatchTabs-importable.web.********************.js`	2.75 kB
`dotcom-rendering/dist/guardian-braze-components-banner.web.********************.js`	14.7 kB
`dotcom-rendering/dist/guardian-braze-components-end-of-article.web.********************.js`	9.29 kB
`dotcom-rendering/dist/GuideAtomWrapper-importable.web.********************.js`	777 B
`dotcom-rendering/dist/HeaderTopBar-importable.web.********************.js`	10.8 kB
`dotcom-rendering/dist/index.web.********************.js`	45.9 kB
`dotcom-rendering/dist/InstagramBlockComponent-importable.web.********************.js`	3.66 kB
`dotcom-rendering/dist/InteractiveBlockComponent-importable.web.********************.js`	6.07 kB
`dotcom-rendering/dist/InteractiveContentsBlockComponent-importable.web.********************.js`	4.63 kB
`dotcom-rendering/dist/InteractiveSupportButton-importable.web.********************.js`	3.88 kB
`dotcom-rendering/dist/KeyEventsCarousel-importable.web.********************.js`	4.14 kB
`dotcom-rendering/dist/KnowledgeQuizAtom-importable.web.********************.js`	3.54 kB
`dotcom-rendering/dist/LatestLinks-importable.web.********************.js`	1.2 kB
`dotcom-rendering/dist/LightboxHash-importable.web.********************.js`	429 B
`dotcom-rendering/dist/LightboxJavascript-importable.web.********************.js`	4.39 kB
`dotcom-rendering/dist/LiveBlogEpic-importable.web.********************.js`	3.92 kB
`dotcom-rendering/dist/Liveness-importable.web.********************.js`	4.9 kB
`dotcom-rendering/dist/ManyNewsletterSignUp-importable.web.********************.js`	5.03 kB
`dotcom-rendering/dist/MapEmbedBlockComponent-importable.web.********************.js`	5.62 kB
`dotcom-rendering/dist/Metrics-importable.web.********************.js`	2.28 kB
`dotcom-rendering/dist/MostViewedFooter-importable.web.********************.js`	5.19 kB
`dotcom-rendering/dist/MostViewedFooterData-importable.web.********************.js`	3.35 kB
`dotcom-rendering/dist/MostViewedRightWrapper-importable.web.********************.js`	3.88 kB
`dotcom-rendering/dist/OnwardsUpper-importable.web.********************.js`	4.16 kB
`dotcom-rendering/dist/PersonalityQuizAtom-importable.web.********************.js`	3.66 kB
`dotcom-rendering/dist/ProfileAtom-importable.web.********************.js`	539 B
`dotcom-rendering/dist/ProfileAtomWrapper-importable.web.********************.js`	797 B
`dotcom-rendering/dist/PulsingDot-importable.web.********************.js`	746 B
`dotcom-rendering/dist/QandaAtom-importable.web.********************.js`	534 B
`dotcom-rendering/dist/ReaderRevenueDev-importable.web.********************.js`	466 B
`dotcom-rendering/dist/readerRevenueDevUtils.web.********************.js`	2.37 kB
`dotcom-rendering/dist/ReaderRevenueLinks-importable.web.********************.js`	6.06 kB
`dotcom-rendering/dist/RelativeTime-importable.web.********************.js`	1.92 kB
`dotcom-rendering/dist/RichLinkComponent-importable.web.********************.js`	6.19 kB
`dotcom-rendering/dist/SecureSignupIframe-importable.web.********************.js`	4.92 kB
`dotcom-rendering/dist/SendAMessage-importable.web.********************.js`	4.39 kB
`dotcom-rendering/dist/SendTargetingParams-importable.web.********************.js`	2.1 kB
`dotcom-rendering/dist/sentry.web.********************.js`	767 B
`dotcom-rendering/dist/SetABTests-importable.web.********************.js`	3.5 kB
`dotcom-rendering/dist/SetAdTargeting-importable.web.********************.js`	480 B
`dotcom-rendering/dist/shimport.web.********************.js`	2.78 kB
`dotcom-rendering/dist/ShowHideContainers-importable.web.********************.js`	643 B
`dotcom-rendering/dist/ShowMore-importable.web.********************.js`	5.69 kB
`dotcom-rendering/dist/SignInGateMain.web.********************.js`	3.89 kB
`dotcom-rendering/dist/SignInGateMainCheckoutComplete.web.********************.js`	4.99 kB
`dotcom-rendering/dist/SignInGateSelector-importable.web.********************.js`	5.54 kB
`dotcom-rendering/dist/SlotBodyEnd-importable.web.********************.js`	6.77 kB
`dotcom-rendering/dist/SpotifyBlockComponent-importable.web.********************.js`	5.47 kB
`dotcom-rendering/dist/StickyBottomBanner-importable.web.********************.js`	5.52 kB
`dotcom-rendering/dist/SubNav-importable.web.********************.js`	2.21 kB
`dotcom-rendering/dist/SupportTheG-importable.web.********************.js`	6.18 kB
`dotcom-rendering/dist/TableOfContents-importable.web.********************.js`	3.1 kB
`dotcom-rendering/dist/TimelineAtom-importable.web.********************.js`	1.24 kB
`dotcom-rendering/dist/TweetBlockComponent-importable.web.********************.js`	1.02 kB
`dotcom-rendering/dist/UnsafeEmbedBlockComponent-importable.web.********************.js`	3.67 kB
`dotcom-rendering/dist/VideoFacebookBlockComponent-importable.web.********************.js`	5.63 kB
`dotcom-rendering/dist/VineBlockComponent-importable.web.********************.js`	3.5 kB
`dotcom-rendering/dist/WeatherWrapper-importable.web.********************.js`	5.42 kB
`dotcom-rendering/dist/YoutubeBlockComponent-importable.web.********************.js`	4 kB

_{compressed-size-action}

.github/workflows/cicd.yml

github-actions · 2023-12-20T14:24:05Z

Deploy build 30448 of `Mobile::mobile-apps-rendering` to CODE

All deployment options

From guardian/actions-riff-raff.

github-actions · 2023-12-20T14:24:06Z

Deploy build 45288 of `dotcom:rendering` to CODE

All deployment options

From guardian/actions-riff-raff.

github-actions · 2023-12-20T14:24:13Z

Deploy build 6428 of `dotcom:rendering-all` to CODE

All deployment options

From guardian/actions-riff-raff.

abeddow91

Great work!

georgeblahblah

🎊

dotcom-rendering/cdk/bin/cdk.ts

dotcom-rendering/cdk/lib/renderingStack.ts

ioannakok

Amazing work!! Just added a few questions for my understanding

prout-bot · 2024-01-04T12:26:38Z

Seen on PROD (merged by @cemms1 8 minutes and 59 seconds ago) Please check your changes!

github-actions bot added the dotcom-rendering label Dec 19, 2023

cemms1 changed the title ~~rename and refactor cdk and riffraff stacks~~ Add new article stack using GuEc2App pattern for dual stack migration Dec 19, 2023

cemms1 force-pushed the use-cdk-pattern branch 2 times, most recently from 9c071e7 to 9216ddf Compare December 20, 2023 10:26

cemms1 commented Dec 20, 2023

View reviewed changes

.github/workflows/cicd.yml Outdated Show resolved Hide resolved

cemms1 force-pushed the use-cdk-pattern branch 3 times, most recently from 9cb2e1b to 94aaeb2 Compare December 20, 2023 14:20

cemms1 force-pushed the use-cdk-pattern branch 3 times, most recently from a3a954c to ba6c283 Compare December 20, 2023 16:45

cemms1 mentioned this pull request Dec 22, 2023

Trial using GuCDK EC2 app pattern #9374

Closed

cemms1 force-pushed the use-cdk-pattern branch 2 times, most recently from e37649e to 3adde32 Compare December 29, 2023 13:42

cemms1 mentioned this pull request Dec 29, 2023

Use new base URL for DCR article endpoints guardian/frontend#26789

Merged

cemms1 marked this pull request as ready for review December 29, 2023 18:13

cemms1 requested a review from a team as a code owner December 29, 2023 18:13

cemms1 force-pushed the use-cdk-pattern branch 2 times, most recently from 6020e0a to 82a4e58 Compare January 2, 2024 17:36

ioannakok mentioned this pull request Jan 3, 2024

Scaling policy #9401

Closed

abeddow91 approved these changes Jan 3, 2024

View reviewed changes

georgeblahblah approved these changes Jan 3, 2024

View reviewed changes

ioannakok reviewed Jan 3, 2024

View reviewed changes

dotcom-rendering/cdk/bin/cdk.ts Outdated Show resolved Hide resolved

ioannakok reviewed Jan 3, 2024

View reviewed changes

dotcom-rendering/cdk/lib/renderingStack.ts Show resolved Hide resolved

ioannakok reviewed Jan 3, 2024

View reviewed changes

dotcom-rendering/cdk/lib/renderingStack.ts Show resolved Hide resolved

ioannakok approved these changes Jan 3, 2024

View reviewed changes

cemms1 added 20 commits January 4, 2024 12:07

include existing stack as well as new one

13b827b

amend publish workflow to account for new article deployment

2a37efa

update AMI parameter and tidy up comments in new stack def

7282907

fix cloudformation name for existing stack in riffraff

4047b9c

separate the old and new riffraff deployments by file

867fc33

deploy using frontend stack (necessary due to riff-raff permissions)

2d2c646

rename stacks to {app}-rendering to avoid clash with frontend apps

a4f4639

update certificate definition

398a876

add additional policies to instance role

d9ed6fc

add dns record set for domain name

ae6bf36

include application logging in cdk pattern props

05a7de5

refactor: reorder props in ec2 pattern

4f2f88b

change recordset to cname

f157e93

specify domainName as CDK stack prop instead of inferring

4d7d820

add SSM parameter for rendering base URL

6f48f4f

docs: improve yaml comments for publish workflow

9e5bd20

update domain name from gutools.co.uk to guardianapis.com

9fad1f5

decrease tolerated 5xx percentage on monitoring config

7451803

docs: adjust naming and comments for deployments

5c3fc9b

style: adjust types for guApp in stack and user data fn

59b84d1

cemms1 added the run_chromatic Runs chromatic when label is applied label Jan 4, 2024

cemms1 force-pushed the use-cdk-pattern branch from 66b960b to 59b84d1 Compare January 4, 2024 12:08

cemms1 merged commit 1eb5e1f into main Jan 4, 2024
30 checks passed

cemms1 deleted the use-cdk-pattern branch January 4, 2024 12:17

prout-bot added Pending-on-PROD Seen-on-PROD and removed Pending-on-PROD labels Jan 4, 2024

JamieB-gu mentioned this pull request Jan 19, 2024

Rendering App Stuck In Alarm Since Traffic Move To Article Rendering App #10265

Closed

georgeblahblah mentioned this pull request May 15, 2024

Tear down "legacy" DCR stack #11422

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add new article stack using GuEc2App pattern for dual stack migration #9955

Add new article stack using GuEc2App pattern for dual stack migration #9955

cemms1 commented Dec 19, 2023 •

edited

Loading

github-actions bot commented Dec 19, 2023 •

edited

Loading

github-actions bot commented Dec 20, 2023 •

edited

Loading

github-actions bot commented Dec 20, 2023 •

edited

Loading

github-actions bot commented Dec 20, 2023 •

edited

Loading

abeddow91 left a comment

georgeblahblah left a comment

ioannakok left a comment

prout-bot commented Jan 4, 2024

Add new article stack using GuEc2App pattern for dual stack migration #9955

Add new article stack using GuEc2App pattern for dual stack migration #9955

Conversation

cemms1 commented Dec 19, 2023 • edited Loading

What does this change?

Why?

github-actions bot commented Dec 19, 2023 • edited Loading

github-actions bot commented Dec 20, 2023 • edited Loading

Deploy build 30448 of Mobile::mobile-apps-rendering to CODE

github-actions bot commented Dec 20, 2023 • edited Loading

Deploy build 45288 of dotcom:rendering to CODE

github-actions bot commented Dec 20, 2023 • edited Loading

Deploy build 6428 of dotcom:rendering-all to CODE

abeddow91 left a comment

Choose a reason for hiding this comment

georgeblahblah left a comment

Choose a reason for hiding this comment

ioannakok left a comment

Choose a reason for hiding this comment

prout-bot commented Jan 4, 2024

cemms1 commented Dec 19, 2023 •

edited

Loading

github-actions bot commented Dec 19, 2023 •

edited

Loading

github-actions bot commented Dec 20, 2023 •

edited

Loading

Deploy build 30448 of `Mobile::mobile-apps-rendering` to CODE

github-actions bot commented Dec 20, 2023 •

edited

Loading

Deploy build 45288 of `dotcom:rendering` to CODE

github-actions bot commented Dec 20, 2023 •

edited

Loading

Deploy build 6428 of `dotcom:rendering-all` to CODE