-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
pm2 cluster mode uses max cpus #8929
Conversation
Size Change: 0 B 🆕 Total Size: 0 B |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So exciting!
From a PR perspective, I think you might need to rebase against main
to bring in the changes which make the AR CI build job for the required status check run.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not totally convinced on PM2 yet, I find its lack of response to the AGPL question to be quite alarming and would prefer to find an alternative "process manager" if possible. But since we are using PM2 it seems a waste to not make use of our extra compute power! Good PR!
I agree we should look for alternatives. Although pm2 is very mature the infrequent updates are concerning too. Have suggested some next steps here. In the mean time given cluster mode is easy to switch on, it will be interesting to see how it performs for us. |
What does this change?
Following #8789 we can try running pm2 in cluster mode.
This PR sets the number of worker processes equal to the max number of cpus available.
This would increase the available cpus from 1 to 2 for our prod instance size of
t4g.small
.Why?
Improve request latency and cpu utilisation of our instances.
Before
After