Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

infra: removes cloudformation yaml from CDK #8669

Merged
merged 5 commits into from
Aug 25, 2023

Conversation

cemms1
Copy link
Contributor

@cemms1 cemms1 commented Aug 24, 2023

What does this change?

Stops importing the Cloudformation yaml into CDK and removes the yaml file entirely.

Why?

Final piece of the puzzle and resolves #7614 🎉

@cemms1 cemms1 changed the base branch from main to cemms1/cdk-migrate-backend-5xx-alarm August 24, 2023 15:42
@github-actions
Copy link

github-actions bot commented Aug 24, 2023

Size Change: 0 B 🆕

Total Size: 0 B

compressed-size-action

Base automatically changed from cemms1/cdk-migrate-backend-5xx-alarm to main August 24, 2023 15:54
@cemms1 cemms1 force-pushed the cemms1/cdk-remove-cloudformation-yaml branch from f690ae5 to 76d01f5 Compare August 24, 2023 15:57
@cemms1 cemms1 added the run_chromatic Runs chromatic when label is applied label Aug 24, 2023
@cemms1 cemms1 marked this pull request as ready for review August 24, 2023 15:58
@cemms1 cemms1 requested a review from a team as a code owner August 24, 2023 15:58
Copy link
Member

@AshCorr AshCorr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🥳

@cemms1 cemms1 merged commit 350ea1e into main Aug 25, 2023
@cemms1 cemms1 deleted the cemms1/cdk-remove-cloudformation-yaml branch August 25, 2023 08:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dotcom-rendering run_chromatic Runs chromatic when label is applied
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[EPIC] CDK
3 participants