Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CDK - migrate scaling policies from cloudformation #8659

Merged
merged 5 commits into from
Aug 23, 2023

Conversation

cemms1
Copy link
Contributor

@cemms1 cemms1 commented Aug 23, 2023

What does this change?

Migrates ScaleUpPolicy and ScaleDownPolicy from Cloudformation to CDK

Resolves #7635, resolves #7634

This PR supersedes and cherry-picks commits from #8514 and #8631

Why?

Part of our migration to CDK

@cemms1 cemms1 added the run_chromatic Runs chromatic when label is applied label Aug 23, 2023
@cemms1 cemms1 marked this pull request as ready for review August 23, 2023 13:46
@cemms1 cemms1 requested a review from a team as a code owner August 23, 2023 13:46
@github-actions
Copy link

github-actions bot commented Aug 23, 2023

Size Change: 0 B

Total Size: 678 kB

ℹ️ View Unchanged
Filename Size
dotcom-rendering/dist/1076.modern.********************.js 3.09 kB
dotcom-rendering/dist/1149.modern.********************.js 2.92 kB
dotcom-rendering/dist/1168.modern.********************.js 19.3 kB
dotcom-rendering/dist/1244.modern.********************.js 869 B
dotcom-rendering/dist/1294.modern.********************.js 5.36 kB
dotcom-rendering/dist/1406.modern.********************.js 5.14 kB
dotcom-rendering/dist/1465.modern.********************.js 3.32 kB
dotcom-rendering/dist/1486.modern.********************.js 747 B
dotcom-rendering/dist/1848.modern.********************.js 647 B
dotcom-rendering/dist/1970.modern.********************.js 13.3 kB
dotcom-rendering/dist/1987.modern.********************.js 3.13 kB
dotcom-rendering/dist/1997.modern.********************.js 747 B
dotcom-rendering/dist/2071.modern.********************.js 748 B
dotcom-rendering/dist/21.modern.********************.js 762 B
dotcom-rendering/dist/2113.modern.********************.js 29.6 kB
dotcom-rendering/dist/2126.modern.********************.js 887 B
dotcom-rendering/dist/2149.modern.********************.js 4.22 kB
dotcom-rendering/dist/2187.modern.********************.js 6.48 kB
dotcom-rendering/dist/2201.modern.********************.js 778 B
dotcom-rendering/dist/2228.modern.********************.js 903 B
dotcom-rendering/dist/2339.modern.********************.js 781 B
dotcom-rendering/dist/2494.modern.********************.js 778 B
dotcom-rendering/dist/2619.modern.********************.js 3.62 kB
dotcom-rendering/dist/275.modern.********************.js 699 B
dotcom-rendering/dist/3024.modern.********************.js 624 B
dotcom-rendering/dist/3146.modern.********************.js 6.53 kB
dotcom-rendering/dist/3239.modern.********************.js 5.02 kB
dotcom-rendering/dist/3358.modern.********************.js 639 B
dotcom-rendering/dist/3549.modern.********************.js 21.3 kB
dotcom-rendering/dist/356.modern.********************.js 830 B
dotcom-rendering/dist/3960.modern.********************.js 621 B
dotcom-rendering/dist/3968.modern.********************.js 3.79 kB
dotcom-rendering/dist/4113.modern.********************.js 760 B
dotcom-rendering/dist/4306.modern.********************.js 6.37 kB
dotcom-rendering/dist/4593.modern.********************.js 1.67 kB
dotcom-rendering/dist/4603.modern.********************.js 3.9 kB
dotcom-rendering/dist/4734.modern.********************.js 761 B
dotcom-rendering/dist/4811.modern.********************.js 2.56 kB
dotcom-rendering/dist/4896.modern.********************.js 2.17 kB
dotcom-rendering/dist/5021.modern.********************.js 967 B
dotcom-rendering/dist/5071.modern.********************.js 944 B
dotcom-rendering/dist/5169.modern.********************.js 3.86 kB
dotcom-rendering/dist/5210.modern.********************.js 913 B
dotcom-rendering/dist/5211.modern.********************.js 2.92 kB
dotcom-rendering/dist/5225.modern.********************.js 6.59 kB
dotcom-rendering/dist/524.modern.********************.js 5.12 kB
dotcom-rendering/dist/5431.modern.********************.js 2.81 kB
dotcom-rendering/dist/5474.modern.********************.js 622 B
dotcom-rendering/dist/5974.modern.********************.js 745 B
dotcom-rendering/dist/6118.modern.********************.js 682 B
dotcom-rendering/dist/640.modern.********************.js 713 B
dotcom-rendering/dist/6437.modern.********************.js 871 B
dotcom-rendering/dist/6534.modern.********************.js 578 B
dotcom-rendering/dist/6541.modern.********************.js 817 B
dotcom-rendering/dist/6840.modern.********************.js 4.7 kB
dotcom-rendering/dist/7039.modern.********************.js 25.8 kB
dotcom-rendering/dist/7133.modern.********************.js 702 B
dotcom-rendering/dist/7305.modern.********************.js 889 B
dotcom-rendering/dist/7401.modern.********************.js 691 B
dotcom-rendering/dist/7498.modern.********************.js 3.64 kB
dotcom-rendering/dist/7688.modern.********************.js 817 B
dotcom-rendering/dist/786.modern.********************.js 480 B
dotcom-rendering/dist/8112.modern.********************.js 3.37 kB
dotcom-rendering/dist/8165.modern.********************.js 929 B
dotcom-rendering/dist/8170.modern.********************.js 492 B
dotcom-rendering/dist/8268.modern.********************.js 5.66 kB
dotcom-rendering/dist/8447.modern.********************.js 965 B
dotcom-rendering/dist/8505.modern.********************.js 559 B
dotcom-rendering/dist/8555.modern.********************.js 691 B
dotcom-rendering/dist/8622.modern.********************.js 862 B
dotcom-rendering/dist/8638.modern.********************.js 836 B
dotcom-rendering/dist/9490.modern.********************.js 829 B
dotcom-rendering/dist/9568.modern.********************.js 5.37 kB
dotcom-rendering/dist/9724.modern.********************.js 5.03 kB
dotcom-rendering/dist/9812.modern.********************.js 2.78 kB
dotcom-rendering/dist/992.modern.********************.js 3.03 kB
dotcom-rendering/dist/AlreadyVisited-importable.modern.********************.js 416 B
dotcom-rendering/dist/AppsFooter-importable.modern.********************.js 2.43 kB
dotcom-rendering/dist/atomIframe.modern.********************.js 514 B
dotcom-rendering/dist/AudioAtomWrapper-importable.modern.********************.js 3.28 kB
dotcom-rendering/dist/AustralianTerritorySwitcher-importable.modern.********************.js 4.09 kB
dotcom-rendering/dist/Branding-importable.modern.********************.js 2.2 kB
dotcom-rendering/dist/braze-web-sdk-core.modern.********************.js 36.9 kB
dotcom-rendering/dist/BrazeMessaging-importable.modern.********************.js 5.47 kB
dotcom-rendering/dist/CalloutBlockComponent-importable.modern.********************.js 6.48 kB
dotcom-rendering/dist/CalloutEmbedBlockComponent-importable.modern.********************.js 5.82 kB
dotcom-rendering/dist/CardCommentCount-importable.modern.********************.js 2.7 kB
dotcom-rendering/dist/Carousel-importable.modern.********************.js 5.32 kB
dotcom-rendering/dist/CarouselForNewsletters-importable.modern.********************.js 5.58 kB
dotcom-rendering/dist/ChartAtomWrapper-importable.modern.********************.js 476 B
dotcom-rendering/dist/CommentCount-importable.modern.********************.js 2.86 kB
dotcom-rendering/dist/discussion.modern.********************.js 397 B
dotcom-rendering/dist/DiscussionContainer-importable.modern.********************.js 23.6 kB
dotcom-rendering/dist/DiscussionMeta-importable.modern.********************.js 3.74 kB
dotcom-rendering/dist/DocumentBlockComponent-importable.modern.********************.js 2.73 kB
dotcom-rendering/dist/EmbedBlockComponent-importable.modern.********************.js 3.27 kB
dotcom-rendering/dist/embedIframe.modern.********************.js 519 B
dotcom-rendering/dist/EnhancePinnedPost-importable.modern.********************.js 1.94 kB
dotcom-rendering/dist/FetchOnwardsData-importable.modern.********************.js 2.01 kB
dotcom-rendering/dist/FilterKeyEventsToggle-importable.modern.********************.js 3.31 kB
dotcom-rendering/dist/FocusStyles-importable.modern.********************.js 511 B
dotcom-rendering/dist/FollowWrapper-importable.modern.********************.js 3.47 kB
dotcom-rendering/dist/frameworks.modern.********************.js 20.8 kB
dotcom-rendering/dist/GetCricketScoreboard-importable.modern.********************.js 3.26 kB
dotcom-rendering/dist/GetMatchNav-importable.modern.********************.js 12.4 kB
dotcom-rendering/dist/GetMatchStats-importable.modern.********************.js 357 B
dotcom-rendering/dist/GetMatchTabs-importable.modern.********************.js 2.31 kB
dotcom-rendering/dist/guardian-braze-components-banner.modern.********************.js 13.4 kB
dotcom-rendering/dist/guardian-braze-components-end-of-article.modern.********************.js 9.01 kB
dotcom-rendering/dist/GuideAtomWrapper-importable.modern.********************.js 4.88 kB
dotcom-rendering/dist/HeaderTopBar-importable.modern.********************.js 10.9 kB
dotcom-rendering/dist/index.modern.********************.js 38.5 kB
dotcom-rendering/dist/InstagramBlockComponent-importable.modern.********************.js 2.8 kB
dotcom-rendering/dist/InteractiveBlockComponent-importable.modern.********************.js 5.75 kB
dotcom-rendering/dist/InteractiveContentsBlockComponent-importable.modern.********************.js 3.79 kB
dotcom-rendering/dist/InteractiveSupportButton-importable.modern.********************.js 4.15 kB
dotcom-rendering/dist/KeyEventsCarousel-importable.modern.********************.js 2.22 kB
dotcom-rendering/dist/KnowledgeQuizAtomWrapper-importable.modern.********************.js 483 B
dotcom-rendering/dist/LatestLinks-importable.modern.********************.js 1.56 kB
dotcom-rendering/dist/LightboxHash-importable.modern.********************.js 425 B
dotcom-rendering/dist/LightboxJavascript-importable.modern.********************.js 4.39 kB
dotcom-rendering/dist/LiveBlogEpic-importable.modern.********************.js 4.95 kB
dotcom-rendering/dist/LiveblogRightMultipleAdSlots-importable.modern.********************.js 1.02 kB
dotcom-rendering/dist/Liveness-importable.modern.********************.js 3.53 kB
dotcom-rendering/dist/ManyNewsletterSignUp-importable.modern.********************.js 6.52 kB
dotcom-rendering/dist/MapEmbedBlockComponent-importable.modern.********************.js 5.34 kB
dotcom-rendering/dist/Metrics-importable.modern.********************.js 2.71 kB
dotcom-rendering/dist/MostViewedFooter-importable.modern.********************.js 5.38 kB
dotcom-rendering/dist/MostViewedFooterData-importable.modern.********************.js 7.61 kB
dotcom-rendering/dist/MostViewedRightWrapper-importable.modern.********************.js 3.7 kB
dotcom-rendering/dist/newsletterEmbedIframe.modern.********************.js 625 B
dotcom-rendering/dist/OnwardsUpper-importable.modern.********************.js 3.59 kB
dotcom-rendering/dist/PersonalityQuizAtomWrapper-importable.modern.********************.js 483 B
dotcom-rendering/dist/ProfileAtomWrapper-importable.modern.********************.js 480 B
dotcom-rendering/dist/PulsingDot-importable.modern.********************.js 746 B
dotcom-rendering/dist/QandaAtomWrapper-importable.modern.********************.js 478 B
dotcom-rendering/dist/ReaderRevenueDev-importable.modern.********************.js 463 B
dotcom-rendering/dist/readerRevenueDevUtils.modern.********************.js 3.02 kB
dotcom-rendering/dist/ReaderRevenueLinks-importable.modern.********************.js 4.91 kB
dotcom-rendering/dist/RecipeMultiplier-importable.modern.********************.js 3.23 kB
dotcom-rendering/dist/relativeTime.modern.********************.js 989 B
dotcom-rendering/dist/RichLinkComponent-importable.modern.********************.js 5.92 kB
dotcom-rendering/dist/SecureSignupIframe-importable.modern.********************.js 4.52 kB
dotcom-rendering/dist/SendAMessage-importable.modern.********************.js 4.39 kB
dotcom-rendering/dist/sentry.modern.********************.js 773 B
dotcom-rendering/dist/SetABTests-importable.modern.********************.js 4.09 kB
dotcom-rendering/dist/SetAdTargeting-importable.modern.********************.js 541 B
dotcom-rendering/dist/ShareCount-importable.modern.********************.js 2.93 kB
dotcom-rendering/dist/shimport.modern.********************.js 2.79 kB
dotcom-rendering/dist/ShowHideContainers-importable.modern.********************.js 638 B
dotcom-rendering/dist/ShowMore-importable.modern.********************.js 5.46 kB
dotcom-rendering/dist/SignInGateMain.modern.********************.js 1.26 kB
dotcom-rendering/dist/SignInGateMainCheckoutComplete.modern.********************.js 2.04 kB
dotcom-rendering/dist/SignInGateSelector-importable.modern.********************.js 3.67 kB
dotcom-rendering/dist/SlotBodyEnd-importable.modern.********************.js 3.1 kB
dotcom-rendering/dist/Snow-importable.modern.********************.js 3.02 kB
dotcom-rendering/dist/SpotifyBlockComponent-importable.modern.********************.js 5.19 kB
dotcom-rendering/dist/StickyBottomBanner-importable.modern.********************.js 4.01 kB
dotcom-rendering/dist/SubNav-importable.modern.********************.js 2.36 kB
dotcom-rendering/dist/SupportTheG-importable.modern.********************.js 5.01 kB
dotcom-rendering/dist/TableOfContents-importable.modern.********************.js 2.79 kB
dotcom-rendering/dist/TimelineAtomWrapper-importable.modern.********************.js 479 B
dotcom-rendering/dist/TweetBlockComponent-importable.modern.********************.js 1.01 kB
dotcom-rendering/dist/UnsafeEmbedBlockComponent-importable.modern.********************.js 2.81 kB
dotcom-rendering/dist/VideoFacebookBlockComponent-importable.modern.********************.js 5.36 kB
dotcom-rendering/dist/VineBlockComponent-importable.modern.********************.js 2.67 kB
dotcom-rendering/dist/WeatherWrapper-importable.modern.********************.js 4.96 kB
dotcom-rendering/dist/YoutubeBlockComponent-importable.modern.********************.js 293 B

compressed-size-action

@cemms1 cemms1 merged commit 4b3bbe1 into main Aug 23, 2023
@cemms1 cemms1 deleted the cemms1/cdk-migrate-scale-policies branch August 23, 2023 15:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dotcom-rendering run_chromatic Runs chromatic when label is applied
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CDK: ScaleUpPolicy Migration CDK: ScaleDownPolicy Migration
3 participants