infra: change definition of load balancer to GuCDK #8566
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: 0 B Total Size: 655 kB ℹ️ View Unchanged
|
This was referenced Aug 15, 2023
sophie-macmillan
approved these changes
Aug 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this change?
This PR definition of load balancer from a
Cfnconstruct (CfnLoadBalancer) to a Gu CDK one (GuClassicLoadBalancer)Why?
As part of the migration to CDK. The load balancer was originally migrated in #8501 as a
Cfntype construct due to the inability to add a specific security group to the Gu CDK construct.When trying to migrate the ASG from Cloudformation in #8507, this
CfnLoadBalancerbecame an issue as we couldn't easily link the LB to the new ASG so this PR finds a way around the original problem by specifying properties to override