test: CDK latency scaling alarm #8547
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: 0 B Total Size: 656 kB ℹ️ View Unchanged
|
ParisaTork
changed the title
ParisaTork
changed the title
|
For the latency scaling alarm, turns out we didn't need this additional endpoint to check it as our latency on the CODE env triggers the alarm very easily (possibly due to the type of instance we're using for the CODE env) The actions of the latency alarm are to scale up and down due to the alert, rather than to send notifications, so we don't need to add the SNS topic and notification endpoint to check this. I'm going to close this PR as not needed. The migration is in #8664. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this change?
As part of our migration to CDK (#7614), we are migrating the latency scaling alarm (#7636). This PR tests the latency scaling alarm to test if it would be triggered correctly and that the SNS topic notifications would work (and therefore PagerDuty notifications).
Why?
We need to ensure that the latency scaling alarm would work in a production environment, as it currently does in its un-CDK-ed state.
Rather than testing completely from end to end, @akash1810 suggested creating a dedicated endpoint in our server that, when accessed with a specific header or cookie, will intentionally induce latency in our application to trigger the latency scaling alarm and test it would work in a production environment. As well as testing the alarm's behaviour, it would also allow us to test its associated actions i.e. SNS topic notifications.
Checklist:
Frontend-CODE-CriticalAlerts