-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
infra: migrate ASG to CDK #8507
Merged
Merged
Changes from 55 commits
Commits
Show all changes
56 commits
Select commit
Hold shift + click to select a range
5373ac6
Initial internal lb migration implementation
ParisaTork d03f2cd
Appease GHA linter with order of imports
ParisaTork 4cbfdaa
Appease GHA linter by using property shorthand for vpc
ParisaTork 6c8db53
infra: migrate asg to cdk and cleanup cloudformation template
cemms1 7c1ab57
refactor: set CIDR block outside vpc def
cemms1 c5a95f7
refactor: remove unnecessary repetition of reason in overriding ids
cemms1 9de918e
Merge branch 'main' into cemms1/cdk-migrate-asg
cemms1 3b0e188
refactor: use destructured region from props
cemms1 cfb7f7a
refactor: move userdata definition to separate file
cemms1 d813f95
infra: use ssm params for ami id
cemms1 1f0130d
update logging stream param
cemms1 0fcd136
remove unused cfn params
cemms1 9717953
String param for S3 Bucket Name
ParisaTork 1c8ae45
Merge branch 'main' into cdk/InternalLoadBalancer
ParisaTork 4cfc29d
cfnOutput experiment
ParisaTork 004ec81
Appease GHA linter - order of imports
ParisaTork 6d156d3
Change S3 Bucket Name
ParisaTork 1e63e74
Merge branch 'cdk/InternalLoadBalancer' of github.com:guardian/dotcom…
ParisaTork 163c46b
use cfnLoadBalancer
DanielCliftonGuardian ece1faf
Update dotcom-rendering.ts
DanielCliftonGuardian b05229a
use load balancer name instead of logical ID
cemms1 adafaa0
Merge branch 'main' into cdk/InternalLoadBalancer
cemms1 e6cc573
infa: remove first char of s3 prefix and add public subnets param
cemms1 dd32d7f
infra: use ref rather than name for lb in cfn
cemms1 9a77a1c
infra: use correct param type for subnet list
cemms1 18334c6
Merge branch 'main' into cdk/InternalLoadBalancer
cemms1 99026c5
remove commented out yaml in cfn
cemms1 aa2b64b
refactor: clean up cfn and cdk code
cemms1 5aa57bd
refactor: destructure for all props
cemms1 6ab4fb8
docs: update description for region
cemms1 fd10e3b
Merge branch 'main' into cemms1/cdk-refactor
cemms1 6a69b67
test: update snapshot
cemms1 847d937
Merge branch 'cemms1/cdk-refactor' into cemms1/cdk-migrate-asg
cemms1 71767f9
rework public subnet definition
cemms1 833683f
remove unused param
cemms1 13f81d6
refactor: use ssmPrefix in path for ssm params
cemms1 fb92c5b
refactor: use destructured app from props
cemms1 bcd84ea
docs: improve docstring for getUserData
cemms1 df92a13
chore: change location of nvmrc check for ami recipe
cemms1 ec5b82a
Merge branch 'main' into cemms1/cdk-migrate-asg
cemms1 3166105
Merge branch 'main' into cemms1/cdk-migrate-asg
cemms1 5eb0c01
refactor: rename userdata file
cemms1 e7f32a0
chore: keep existing (unused) params in cfn in case of rollback
cemms1 ed5fb0a
remove vpcid param
cemms1 856dfda
infra: switch load balancer type (#8558)
cemms1 2b9e58b
Merge branch 'main' into cemms1/cdk-migrate-asg
cemms1 c5d2888
Merge branch 'cemms1/cdk-change-lb-definition' into cemms1/cdk-migrat…
cemms1 960cde0
remove whitespace from start of userdata
cemms1 eb5190a
remove whitespace in userdata
cemms1 6139122
change usedata to array join
cemms1 9301a74
remove imdsv2 requirement
cemms1 02a9066
base64 encode userdata
cemms1 16a7834
use private vpc and un-encode userdata
cemms1 f8aa7d9
Merge branch 'cemms1/cdk-change-lb-definition' into cemms1/cdk-migrat…
cemms1 d53b1f0
Merge branch 'main' into cemms1/cdk-migrate-asg
cemms1 5449ce6
Merge branch 'main' into cemms1/cdk-migrate-asg
cemms1 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Future optimisation note to parameterise these values