infra: Migrate InstanceRole to CDK #8495
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DanielCliftonGuardian
added
the
run_chromatic
|
Size Change: 0 B Total Size: 654 kB ℹ️ View Unchanged
|
cemms1
reviewed
Aug 7, 2023
Co-Authored-By: Charlotte Emms <[email protected]> Co-Authored-By: Parisa Tork <[email protected]>
ParisaTork
changed the title
cemms1
reviewed
Aug 8, 2023
cemms1
reviewed
Aug 8, 2023
ParisaTork
reviewed
Aug 8, 2023
| actions: ['cloudwatch:*', 'logs:*'], | ||
| resources: ['*'] | ||
| }), | ||
| new GuAllowPolicy(this, 'AllowPolicyDescribeEc2Autoscaling', { |
There was a problem hiding this comment.
We can remove the AllowPolicyDescribeEc2Autoscaling policy, because it's already covered by the default GuDescribeEC2Policy: https://github.com/guardian/cdk/blob/1d5918085d533513de0b165be815019f98e880ad/src/constructs/iam/roles/instance-role.ts#L51 (Non-blocking though, so let's remove redundant policies in another PR)
9 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this change?
Migrate InstanceRole to CDK to resolve #7629
Tested on code
Why?
Part of our migration to CDK