infra: Migrate internal load balancer security group to CDK #8428
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: 0 B Total Size: 650 kB ℹ️ View Unchanged
|
ParisaTork
changed the title
jamesgorrie
reviewed
Aug 3, 2023
| @@ -4,10 +4,12 @@ import { DotcomRendering } from '../lib/dotcom-rendering'; | |||
|
|
|||
| const app = new App(); | |||
| new DotcomRendering(app, 'DotcomRendering-PROD', { | |||
| app: 'rendering', | |||
There was a problem hiding this comment.
From what I can see in the logs, this is actually called dotcom-rendering.
Or is this set elsewhere?
There was a problem hiding this comment.
Our "naming" is REALLY inconsistent, but I believe "rendering" is correct. Its set here: https://github.com/guardian/dotcom-rendering/pull/8428/files#diff-27418f23c8cbec59b8753ad54c095fd59254f5626f1a48ce77acd161fb3ab3c7R17
AWS Resource name =/= ELK App name unfortunately :/
jamesgorrie
reviewed
Aug 3, 2023
DanielCliftonGuardian
force-pushed
the
cdk-InternalLoadBalancerSecurityGroup
branch
2 times, most recently
from
32eb7f6 to
183262d
Compare
Co-authored-by: Parisa Tork <[email protected]>
cemms1
force-pushed
the
cdk-InternalLoadBalancerSecurityGroup
branch
from
0d9dd9f to
1ac23c6
Compare
9 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this change?
Replaces
InternalLoadBalancerSecurityGroupresource in Cloudformation with a CDK-defined one.Why?
Part of our migration from Cloudformation to CDK.
Resolves #7625.