Bump @guardian/libs to 12.0.1 #7082
Merged
+61
−14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jamesgorrie
approved these changes
Jan 30, 2023
|
Size Change: +61 B (0%) Total Size: 2.29 MB ℹ️ View Unchanged
|
⚡️ Lighthouse report for the changes in this PRLighthouse tested 2 URLs Report for Article
Report for Front
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this change?
Bump
@guardian/libsto 12.0.1 to bring in: guardian/csnx#388Why?
To reduce SecurityError occurrences in Sentry
Screenshots
Next steps
There are still instances of
SecurityErrorin DCR caused by direct references to window.localStorage. All references to localStorage in DCR should be moved to use@guardian/libs/storageto make sure that exceptions are properly handled.