Dev route for DCR email-newsletters page #6716
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: +6.24 kB (0%) Total Size: 2.39 MB
ℹ️ View Unchanged
|
⚡️ Lighthouse report for the changes in this PRLighthouse tested 2 URLs Report for Article
Report for Front
|
dblatcher
changed the title
|
"This PR is stale because it has been open 30 days with no activity. Unless a comment is added or the “stale” label removed, this will be closed in 3 days" |
|
This PR was closed because it has been stalled for 3 days with no activity. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this change?
Adds a new route to the dev server (IE no effect on Prod) to serve a test version of a DCR newsletters page using a static list of newsletters and static page configuration data.
This involved generalising some of the code used to render article pages to create a
StandAlonePagecomponent with similar structure to the existing Layout components, but acting as a container for any content passed aschildren(in this case theNewslettersListcomponent.Testing:
make devWhy?
This would be a first step to rendering the "/email-newsletters" page using DCR instead of frontend. The intent would be for fronted to post the request for the rendered page to DCR, with the newsletters data and page data (Nav, Config, Header, cannonical URL etc) as part of the request body, in much the same way frontend requests article pages.
It could also act as a template for rendering other non-article & non-front pages with DCR.
More details on this post: #6473
Screenshots