Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WithABProvider #3945

Merged
merged 4 commits into from
Feb 9, 2022
Merged

WithABProvider #3945

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
617985e
refactor: Created `WithAB` wrapper
oliverlloyd Feb 8, 2022
35243ef
refactor: `WithAB` > `WithABProvider`
oliverlloyd Feb 9, 2022
f5ed7aa
Update dotcom-rendering/src/web/components/WithAB.tsx
oliverlloyd Feb 9, 2022
4ff94ad
Merge branch 'oliver/withab' of https://github.com/guardian/dotcom-re…
oliverlloyd Feb 9, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 4 additions & 17 deletions dotcom-rendering/src/web/components/BootReact.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,13 +1,11 @@
import ReactDOM from 'react-dom';

import { App } from '@root/src/web/components/App';
import { ABProvider } from '@guardian/ab-react';
import { tests } from '@frontend/web/experiments/ab-tests';
import { getForcedParticipationsFromUrl } from '@frontend/web/lib/getAbUrlHash';
import { getCypressSwitches } from '@frontend/web/experiments/cypress-switches';
import { loadableReady } from '@loadable/component';
import { getOphanRecordFunction } from '@root/src/web/browser/ophan/ophan';
import { getCookie } from '@guardian/libs';
import { WithABProvider } from './WithABProvider';

type Props = {
CAPI: CAPIBrowserType;
Expand All @@ -27,28 +25,17 @@ export const BootReact = ({ CAPI }: Props) => {

const ophanRecord = getOphanRecordFunction();

const windowHash = window && window.location && window.location.hash;

// Get the forced switches to use for when running within cypress
// Is empty object if not in cypress
const cypressAbSwitches = getCypressSwitches();

loadableReady(() => {
ReactDOM.render(
<ABProvider
<WithABProvider
arrayOfTestObjects={tests}
abTestSwitches={{
...CAPI.config.switches,
...cypressAbSwitches, // by adding cypress switches below CAPI, we can override any production switch in Cypress
}}
abTestSwitches={CAPI.config.switches}
pageIsSensitive={CAPI.config.isSensitive}
mvtMaxValue={1000000}
mvtId={mvtId}
ophanRecord={ophanRecord}
forcedTestVariants={getForcedParticipationsFromUrl(windowHash)}
>
<App CAPI={CAPI} ophanRecord={ophanRecord} />
</ABProvider>,
</WithABProvider>,

document.getElementById('react-root'),
);
Expand Down
42 changes: 42 additions & 0 deletions dotcom-rendering/src/web/components/WithABProvider.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,42 @@
import { CoreAPIConfig, OphanAPIConfig } from '@guardian/ab-core/dist/types';
import { ABProvider } from '@guardian/ab-react';
import { getCypressSwitches } from '../experiments/cypress-switches';
import { getForcedParticipationsFromUrl } from '../lib/getAbUrlHash';

type Props = {
arrayOfTestObjects: CoreAPIConfig['arrayOfTestObjects'];
abTestSwitches: CoreAPIConfig['abTestSwitches'];
pageIsSensitive: CoreAPIConfig['pageIsSensitive'];
mvtId: CoreAPIConfig['mvtId'];
ophanRecord: OphanAPIConfig['ophanRecord'];
children: JSX.Element;
};
export const WithABProvider = ({
arrayOfTestObjects,
abTestSwitches,
pageIsSensitive,
mvtId,
ophanRecord,
children,
}: Props) => {
const windowHash = window?.location.hash;
// Get the forced switches to use for when running within cypress
// Is empty object if not in cypress
const cypressAbSwitches = getCypressSwitches();
return (
<ABProvider
arrayOfTestObjects={arrayOfTestObjects}
abTestSwitches={{
...abTestSwitches,
...cypressAbSwitches, // by adding cypress switches below CAPI, we can override any production switch in Cypress
}}
pageIsSensitive={pageIsSensitive}
mvtMaxValue={1000000}
mvtId={mvtId}
ophanRecord={ophanRecord}
forcedTestVariants={getForcedParticipationsFromUrl(windowHash)}
>
{children}
</ABProvider>
);
};