Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show contributor badges in comments #3469

Merged
merged 1 commit into from
Sep 27, 2021
Merged

Conversation

DavidLawes
Copy link
Contributor

What does this change?

Bump the version of discussion-rendering to ensure comments from contributors have the expected badge.

Why?

For articles rendered via DCR, Central Production reported that comments from Contributors did not have the expected badges.

In frontend we marked comments from contributors with an associated badge. https://github.com/guardian/frontend/blob/main/discussion/app/views/fragments/commentBadges.scala.html#L8

This change adds the equivalent functionality into DCR. Note that the badge is added as part of discussion-rendering, guardian/discussion-rendering#524

Before

Currently, for articles rendered via DCR, contributors did not have a badge:
Screenshot 2021-09-24 at 17 13 38

After

After this change, comments from contributors have a badge:
Screenshot 2021-09-24 at 17 14 26

@github-actions
Copy link

Size Change: -28.2 kB (-3%)

Total Size: 921 kB

Filename Size Change
dist/922.js 3.58 kB -10 B (0%)
dist/922.legacy.js 3.69 kB -7 B (0%)
dist/EditionDropdown.js 693 B -2 B (0%)
dist/EditionDropdown.legacy.js 702 B -2 B (0%)
dist/elements-CalloutBlockComponent.js 5.83 kB -20 B (0%)
dist/elements-CalloutBlockComponent.legacy.js 6.18 kB -18 B (0%)
dist/elements-DocumentBlockComponent.js 568 B -6 B (-1%)
dist/elements-DocumentBlockComponent.legacy.js 599 B -5 B (-1%)
dist/elements-InteractiveBlockComponent.js 2.57 kB -16 B (-1%)
dist/elements-InteractiveBlockComponent.legacy.js 2.67 kB -16 B (-1%)
dist/elements-InteractiveContentsBlockElement.js 1.87 kB -29 B (-2%)
dist/elements-InteractiveContentsBlockElement.legacy.js 1.95 kB -31 B (-2%)
dist/elements-MapEmbedBlockComponent.js 1.53 kB -16 B (-1%)
dist/elements-MapEmbedBlockComponent.legacy.js 1.59 kB -14 B (-1%)
dist/elements-RichLinkComponent.js 3.28 kB -27 B (-1%)
dist/elements-RichLinkComponent.legacy.js 3.32 kB -25 B (-1%)
dist/elements-SpotifyBlockComponent.js 1.46 kB -12 B (-1%)
dist/elements-SpotifyBlockComponent.legacy.js 1.52 kB -15 B (-1%)
dist/elements-VideoFacebookBlockComponent.js 1.53 kB -14 B (-1%)
dist/elements-VideoFacebookBlockComponent.legacy.js 1.59 kB -11 B (-1%)
dist/elements-VineBlockComponent.js 581 B -5 B (-1%)
dist/elements-VineBlockComponent.legacy.js 598 B -3 B (0%)
dist/elements-YoutubeBlockComponent.js 2.07 kB -28 B (-1%)
dist/elements-YoutubeBlockComponent.legacy.js 2.15 kB -29 B (-1%)
dist/frontend.server.js 295 kB -3.82 kB (-1%)
dist/GetMatchStats.js 3.28 kB -9 B (0%)
dist/GetMatchStats.legacy.js 3.35 kB -11 B (0%)
dist/guardian-braze-components-banner.js 9.82 kB -36 B (0%)
dist/guardian-braze-components-banner.legacy.js 9.82 kB -36 B (0%)
dist/guardian-braze-components-end-of-article.js 6.49 kB -46 B (-1%)
dist/guardian-braze-components-end-of-article.legacy.js 6.5 kB -45 B (-1%)
dist/MostViewedFooterData.js 6.32 kB -33 B (-1%)
dist/MostViewedFooterData.legacy.js 6.41 kB -35 B (-1%)
dist/MostViewedRightWrapper.js 5.62 kB -30 B (-1%)
dist/MostViewedRightWrapper.legacy.js 5.87 kB -29 B (0%)
dist/OnwardsLower.js 11.3 kB -46 B (0%)
dist/OnwardsLower.legacy.js 11.6 kB -42 B (0%)
dist/OnwardsUpper.js 12.4 kB -58 B (0%)
dist/OnwardsUpper.legacy.js 12.7 kB -45 B (0%)
dist/react.js 135 kB -11.6 kB (-8%)
dist/react.legacy.js 141 kB -11.9 kB (-8%)
dist/SignInGateMain.js 1.84 kB -20 B (-1%)
dist/SignInGateMain.legacy.js 1.88 kB -19 B (-1%)
ℹ️ View Unchanged
Filename Size
dist/974.js 21.1 kB
dist/974.legacy.js 21.1 kB
dist/atomIframe.js 1.87 kB
dist/atomIframe.legacy.js 2.13 kB
dist/braze-web-sdk-core.js 36.1 kB
dist/braze-web-sdk-core.legacy.js 36.1 kB
dist/coreVitals.js 3.73 kB
dist/coreVitals.legacy.js 6.43 kB
dist/dynamicImport.js 3 kB
dist/dynamicImport.legacy.js 3.27 kB
dist/elements-InstagramBlockComponent.js 435 B
dist/elements-InstagramBlockComponent.legacy.js 453 B
dist/embedIframe.js 1.88 kB
dist/embedIframe.legacy.js 2.13 kB
dist/ga.js 3.87 kB
dist/ga.legacy.js 4.1 kB
dist/newsletterEmbedIframe.js 1.83 kB
dist/newsletterEmbedIframe.legacy.js 2.08 kB
dist/ophan.js 7.22 kB
dist/ophan.legacy.js 7.41 kB
dist/sentry.js 675 B
dist/sentry.legacy.js 686 B
dist/sentryLoader.js 3.25 kB
dist/sentryLoader.legacy.js 5.94 kB
dist/shimport.js 2.75 kB
dist/shimport.legacy.js 2.76 kB

compressed-size-action

Copy link
Contributor

@nitro-marky nitro-marky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@DavidLawes DavidLawes merged commit 86643df into main Sep 27, 2021
@DavidLawes DavidLawes deleted the dlawes/add-contributor-badge branch September 27, 2021 11:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants