Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove AMP validation CI/CD step #13095

Closed
wants to merge 1 commit into from
Closed

Remove AMP validation CI/CD step #13095

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 0 additions & 26 deletions .github/workflows/amp.yml
View file
Open in desktop

This file was deleted.

6 changes: 0 additions & 6 deletions .github/workflows/cicd.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,12 +26,6 @@ jobs:
with:
container-image: ${{ needs.container.outputs.container-image }}

amp:
needs: [container]
uses: ./.github/workflows/amp.yml
with:
container-image: ${{ needs.container.outputs.container-image }}

publish:
permissions:
id-token: write
Expand Down
4 changes: 0 additions & 4 deletions dotcom-rendering/makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -82,10 +82,6 @@ playwright-open: clear clean-dist install build
$(call log, "starting DEV server and opening Playwright UI")
@pnpm playwright:open

ampValidation: clean-dist install
$(call log, "starting AMP Validation test")
@node scripts/test/amp-validation.js

buildCheck:
$(call log, "checking build files")
@node ./scripts/test/build-check.js
Expand Down
58 changes: 0 additions & 58 deletions dotcom-rendering/scripts/test/amp-validation.js
View file
Open in desktop

This file was deleted.

Loading