Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add crossword design #13083

Merged
merged 7 commits into from
Jan 10, 2025
Merged

Add crossword design #13083

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
7559d9f
add crossword design
SiAdcock Jan 7, 2025
0fce0e3
Merge branch 'main' into sa-crossword-design
SiAdcock Jan 7, 2025
e704a00
Merge branch 'main' into sa-crossword-design
SiAdcock Jan 7, 2025
908da71
add crossword design to switch case of supported designs
SiAdcock Jan 7, 2025
d489dd3
Merge branch 'main' into sa-crossword-design
SiAdcock Jan 10, 2025
0401a3a
Merge branch 'main' into sa-crossword-design
SiAdcock Jan 10, 2025
2e4d565
move crossword design to the end of the articledesign
SiAdcock Jan 10, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions dotcom-rendering/src/lib/articleFormat.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,7 @@ export enum ArticleDesign {
NewsletterSignup,
Timeline,
Profile,
Crossword,
}

export enum ArticleDisplay {
Expand Down Expand Up @@ -115,6 +116,8 @@ export const decideDesign = ({ design }: Partial<FEFormat>): ArticleDesign => {
return ArticleDesign.Timeline;
case 'ProfileDesign':
return ArticleDesign.Profile;
case 'CrosswordDesign':
return ArticleDesign.Crossword;
default:
return ArticleDesign.Standard;
}
Expand Down Expand Up @@ -230,6 +233,8 @@ const designToFEDesign = (design: ArticleDesign): FEDesign => {
return 'AudioDesign';
case ArticleDesign.Video:
return 'VideoDesign';
case ArticleDesign.Crossword:
return 'CrosswordDesign';
case ArticleDesign.Review:
return 'ReviewDesign';
case ArticleDesign.Analysis:
Expand Down
1 change: 1 addition & 0 deletions dotcom-rendering/src/model/article-schema.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4220,6 +4220,7 @@
"ArticleDesign",
"AudioDesign",
"CommentDesign",
"CrosswordDesign",
"DeadBlogDesign",
"EditorialDesign",
"ExplainerDesign",
Expand Down
1 change: 1 addition & 0 deletions dotcom-rendering/src/model/front-schema.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3055,6 +3055,7 @@
"ArticleDesign",
"AudioDesign",
"CommentDesign",
"CrosswordDesign",
"DeadBlogDesign",
"EditorialDesign",
"ExplainerDesign",
Expand Down
1 change: 1 addition & 0 deletions dotcom-rendering/src/model/tag-page-schema.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1282,6 +1282,7 @@
"ArticleDesign",
"AudioDesign",
"CommentDesign",
"CrosswordDesign",
"DeadBlogDesign",
"EditorialDesign",
"ExplainerDesign",
Expand Down
1 change: 1 addition & 0 deletions dotcom-rendering/src/types/frontend.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -183,6 +183,7 @@ export type FEDesign =
| 'GalleryDesign'
| 'AudioDesign'
| 'VideoDesign'
| 'CrosswordDesign'
| 'ReviewDesign'
| 'AnalysisDesign'
| 'CommentDesign'
Expand Down
Loading