Media card alignment #13040
Merged
Media card alignment #13040
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello 👋! When you're ready to run Chromatic, please apply the You will need to reapply the label each time you want to run Chromatic. |
|
Size Change: +41 B (0%) Total Size: 942 kB ℹ️ View Unchanged
|
github-actions
bot
removed
the
run_chromatic
| @@ -450,9 +453,9 @@ export const Card = ({ | |||
| - * Media cards have contrasting background colours. We add additional | |||
| * padding to these cards to keep the text readable. | |||
| - */ | |||
| const hasBackgroundColour = isMediaCard(format); | |||
| const isMediaCard = isAMediaCard(format); | |||
There was a problem hiding this comment.
This is a better name for this var 👍 I lazily left it alone as it clashed with the method name.
Georges-GNM
reviewed
Dec 19, 2024
| @@ -7,7 +7,7 @@ import { | |||
| } from '@guardian/source/foundations'; | |||
| import { Hide, Link } from '@guardian/source/react-components'; | |||
| import { ArticleDesign, type ArticleFormat } from '../../lib/articleFormat'; | |||
| import { isMediaCard } from '../../lib/cardHelpers'; | |||
| import { isMediaCard as isAMediaCard } from '../../lib/cardHelpers'; | |||
There was a problem hiding this comment.
Yeah, think I prefer this to what you had earlier (where isAMediaCard was the const declared on line 456) 👍
Georges-GNM
approved these changes
Dec 19, 2024
|
Seen on PROD (merged by @abeddow91 15 minutes and 3 seconds ago) Please check your changes! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this change?
Updates the alignment of cards in beta containers if they are media cards. If they are, the image should always be at the top and the headline should always be inner.
Why?
This is as per designs.
Screenshots