-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Skip flaky Chromatic tests #13017
Draft
domlander
wants to merge
1
commit into
main
Choose a base branch
from
doml/chromatic
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Skip flaky Chromatic tests #13017
+60
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
removed
the
run_chromatic
Runs chromatic when label is applied
label
Dec 16, 2024
domlander
force-pushed
the
doml/chromatic
branch
from
December 16, 2024 17:06
a6fac48
to
223c03e
Compare
Size Change: 0 B Total Size: 942 kB ℹ️ View Unchanged
|
domlander
force-pushed
the
doml/chromatic
branch
from
December 16, 2024 17:14
223c03e
to
82a1bf4
Compare
github-actions
bot
removed
the
run_chromatic
Runs chromatic when label is applied
label
Dec 16, 2024
github-actions
bot
removed
the
run_chromatic
Runs chromatic when label is applied
label
Dec 16, 2024
domlander
force-pushed
the
doml/chromatic
branch
from
December 23, 2024 10:18
82a1bf4
to
bee2867
Compare
domlander
force-pushed
the
doml/chromatic
branch
from
December 23, 2024 10:58
bee2867
to
a5c5cce
Compare
github-actions
bot
removed
the
run_chromatic
Runs chromatic when label is applied
label
Dec 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #13015
What does this change?
Skips five flaky Chromatic tests. These tests often record false positives in Chromatic runs.
Why?
These slow down the development workflow of many teams. There is a risk that we will miss unexpected changes because of this, so we should look to resolve this as soon as possible.