Media Cards: Replace gallery media icon with pill #13010
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: +468 B (+0.05%) Total Size: 942 kB
ℹ️ View Unchanged
|
github-actions
bot
removed
the
run_chromatic
jamesmockett
force-pushed
the
jm/gallery-pill-count
branch
from
4fec9c8 to
360bc32
Compare
github-actions
bot
removed
the
run_chromatic
jamesmockett
force-pushed
the
jm/gallery-pill-count
branch
from
ee82a68 to
da00fd9
Compare
jamesmockett
force-pushed
the
jm/gallery-pill-count
branch
from
da00fd9 to
839e4bf
Compare
github-actions
bot
removed
the
run_chromatic
|
Hello 👋! When you're ready to run Chromatic, please apply the You will need to reapply the label each time you want to run Chromatic. |
abeddow91
reviewed
Dec 19, 2024
| > | ||
| <Pill | ||
| prefix="Gallery" | ||
| content={galleryCount?.toString() ?? ''} |
There was a problem hiding this comment.
If we want gallery count to be used as a string, would it be worth lifting this up and converting in the card enhancer?
There was a problem hiding this comment.
I think it makes sense that gallery count is a number, but was considering reworking the Pill component so that the conversion isn't needed. (Either extending the types that content accepts, or removing it entirely and making Pill a wrapper for child elements.)
|
We want to release the gallery and podcast pills together. As most of the layout and logic changes are shared I'm closing this in favour of a combined PR that replaces both media icons: #13035 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this change?
Updates media cards to show a pill component in place of the media icon for galleries. The pill is displayed below the headline and trail text in place of age and comment count, and includes the number of images in the gallery.
This is dependent upon #12980 which updates the media card colour palette.
Why?
This is an incremental change which forms part of a larger body of work to update the design of media cards
Screenshots