Fix images in cards for old articles in Onwards Content AB test #13006
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
domlander
commented
Dec 13, 2024
| @@ -25,6 +26,8 @@ const containerStyles = css` | |||
|
|
|||
| ${from.leftCol} { | |||
| flex-direction: row; | |||
| } | |||
| ${from.wide} { | |||
There was a problem hiding this comment.
To align cards with the other containers at leftCol screen sizes
domlander
commented
Dec 13, 2024
| @@ -126,7 +133,7 @@ export const BigSixOnwardsContent = ({ url, discussionApiUrl }: Props) => { | |||
| imagePositionOnDesktop="right" | |||
| imagePositionOnMobile="top" | |||
| imageSize="large" | |||
| imageLoading="lazy" | |||
| imageLoading="eager" | |||
There was a problem hiding this comment.
We only load this component when the user has scrolled to it, so we should load eagerly. Mirrors functionality in Carousel component where the four non-hidden cards images are eagerly loaded.
|
Size Change: +18 B (0%) Total Size: 942 kB ℹ️ View Unchanged
|
domlander
force-pushed
the
doml/fix-images-onwards-content-test
branch
from
749bb68 to
dcdc75a
Compare
domlander
changed the title
github-actions
bot
removed
the
run_chromatic
domlander
commented
Dec 13, 2024
| ? trail.masterImage | ||
| : trail.image | ||
| ? getSourceImageUrl(trail.image) | ||
| : '', |
There was a problem hiding this comment.
Nested ternary 🤢. If the AB test is successful, then it will be worth extracting this to a function (and not using the deprecated getSourceImageUrl function).
DanielCliftonGuardian
approved these changes
Dec 13, 2024
|
Seen on PROD (merged by @domlander 8 minutes and 51 seconds ago) Please check your changes! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this change?
Show images on cards containing old articles
Why?
Images did not display on some old articles
Screenshots