-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Re-implement show/hide buttons on containers #12986
Draft
cemms1
wants to merge
2
commits into
main
Choose a base branch
from
cemms1/reimplement-show-hide
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
+119
−149
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cemms1
commented
Dec 11, 2024
Size Change: +1.9 kB (+0.2%) Total Size: 940 kB
ℹ️ View Unchanged
|
cemms1
force-pushed
the
cemms1/reimplement-show-hide
branch
from
January 2, 2025 09:50
58a9e56
to
a502849
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this change?
ShowHideButton
) which manages its own state as well as updating global stateShowHideContainers
)Note
This might "fix" a problem with the data-link-names because they were previously firing the opposite events (show was sending "hide" events and vice versa)
Data Design and Data Journalism must be updated before this PR goes ahead so that we can make a note of the time this was "fixed" (if this does in fact fix that issue)
Why?
Simplifies logic and makes this easier to understand for future developers.
Screenshots