Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include beta collection types in ad placement logic for desktop #12942

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Include beta collection types in ad placement logic for desktop #12942

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
10e9623
include beta collection types in ad placement logic
cemms1 Dec 3, 2024
3319060
Add 6 as value for collection height of very long containers that are…
cemms1 Dec 11, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
33 changes: 32 additions & 1 deletion dotcom-rendering/src/lib/getFrontsAdPositions.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,7 @@ type GroupedCounts = {
veryBig: number;
big: number;
standard: number;
splash: number;
};

type AdCandidate = Pick<DCRCollectionType, 'collectionType'>;
Expand Down Expand Up @@ -75,13 +76,14 @@ const getMobileAdPositions = (collections: AdCandidate[]): number[] => {
*
* A result of 3 would approximately be the height of a typical desktop viewport (~900px).
* A result of 1 would be a third of the height, a result of 1.5 would be half, etc.
* A result of 6 indicates a container is at least double the height of a typical desktop viewport.
*/
const getCollectionHeight = (
collction: Pick<
DCRCollectionType,
'collectionType' | 'containerPalette' | 'grouped'
>,
): 0.5 | 1 | 1.5 | 2 | 2.5 | 3 => {
): 0.5 | 1 | 1.5 | 2 | 2.5 | 3 | 6 => {
const { collectionType, containerPalette, grouped } = collction;

if (containerPalette === 'PodcastPalette') {
Expand All @@ -95,18 +97,22 @@ const getCollectionHeight = (
veryBig: grouped.veryBig.length,
big: grouped.big.length,
standard: grouped.standard.length,
splash: grouped.splash.length,
};

switch (collectionType) {
// Some thrashers are very small. Since we'd prefer to have ads above content rather than thrashers,
// err on the side of inserting fewer ads, by setting the number on the small side for thrashers
case 'fixed/thrasher':
case 'scrollable/small':
return 0.5;

case 'fixed/small/slow-IV':
case 'fixed/small/slow-V-mpu':
case 'nav/list':
case 'nav/media-list':
case 'scrollable/medium':
case 'static/medium/4':
return 1;

case 'fixed/small/slow-I':
Expand All @@ -116,13 +122,15 @@ const getCollectionHeight = (
case 'fixed/small/fast-VIII':
case 'fixed/video':
case 'fixed/video/vertical':
case 'scrollable/feature':
return 1.5;

case 'fixed/medium/slow-VI':
case 'fixed/medium/slow-VII':
case 'fixed/medium/slow-XII-mpu':
case 'fixed/medium/fast-XI':
case 'fixed/medium/fast-XII':
case 'static/feature/2':
return 2;

case 'fixed/large/slow-XIV':
Expand Down Expand Up @@ -157,6 +165,29 @@ const getCollectionHeight = (
}
return 1;

case 'flexible/special':
if (groupedCounts.snap && !groupedCounts.splash) {
return 1.5;
} else if (groupedCounts.splash && !groupedCounts.standard) {
return 2.5;
} else {
return 3;
}

case 'flexible/general':
if (groupedCounts.splash && !groupedCounts.standard) {
return 2.5;
} else if (groupedCounts.splash && groupedCounts.standard > 2) {
return 6;
} else if (
grouped.splash[0]?.boostLevel === 'megaboost' ||
grouped.splash[0]?.boostLevel === 'gigaboost'
) {
return 6;
} else {
return 3;
}

default:
return 1; // Unknown collection type.
}
Expand Down
Loading