Replace fetch-mock dependency with custom fetch mock utility #12551
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
There was a problem hiding this comment.
CodeQL found more than 20 potential problems in the proposed changes. Check the Files changed tab for more details.
marjisound
force-pushed
the
marji/fix-fetch-mock-issue
branch
from
c1573f6 to
c7eaea1
Compare
marjisound
force-pushed
the
marji/fix-fetch-mock-issue
branch
from
c7eaea1 to
8f767e2
Compare
|
Size Change: 0 B Total Size: 904 kB ℹ️ View Unchanged
|
github-actions
bot
removed
the
run_chromatic
github-actions
bot
removed
the
run_chromatic
marjisound
force-pushed
the
marji/fix-fetch-mock-issue
branch
from
f411246 to
f4e6acd
Compare
github-actions
bot
removed
the
run_chromatic
github-actions
bot
removed
the
run_chromatic
github-actions
bot
removed
the
run_chromatic
marjisound
force-pushed
the
marji/fix-fetch-mock-issue
branch
2 times, most recently
from
b4982f8 to
82cf850
Compare
github-actions
bot
removed
the
run_chromatic
marjisound
commented
Oct 16, 2024
| import { GroupedNewslettersList } from './GroupedNewsletterList'; | ||
| import { ManyNewsletterSignUp } from './ManyNewsletterSignUp.importable'; | ||
|
|
||
| mockRESTCalls(); |
There was a problem hiding this comment.
We don't need to add mockFetch to global.fetch here, because that's done in preview.js
marjisound
commented
Oct 16, 2024
|
|
||
| export const jestMockFetch = (): void => { | ||
| global.fetch = jest.fn(mockFetch); | ||
| }; |
There was a problem hiding this comment.
This is jest specific setup for mocking fetch.
marjisound
force-pushed
the
marji/fix-fetch-mock-issue
branch
from
82cf850 to
2249e2a
Compare
github-actions
bot
removed
the
run_chromatic
|
Hello 👋! When you're ready to run Chromatic, please apply the You will need to reapply the label each time you want to run Chromatic. |
marjisound
force-pushed
the
marji/fix-fetch-mock-issue
branch
from
2249e2a to
7020275
Compare
github-actions
bot
removed
the
run_chromatic
marjisound
force-pushed
the
marji/fix-fetch-mock-issue
branch
from
7020275 to
98880a2
Compare
github-actions
bot
removed
the
run_chromatic
|
Seen on PROD (merged by @marjisound 9 minutes and 50 seconds ago) Please check your changes! |
|
Great work on this @marjisound ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this change?
This pull request removes the fetch-mock dependency and replaces it with a custom fetch mock implementation across our Jest tests and Storybook configuration.
We initially aimed to upgrade fetch-mock to address known security vulnerabilities. However, upgrading to a more recent version introduced compatibility Issues, hence we decided to get rid of this dependency
Key Changes:
mockRESTCallsInJest.tsand Updated Storybook preview.ts file to use the new custom mockFetch for all stories.Why?
To avoid the security vulnerability fetch-mock library had in version 9