Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump commercial to 22.1.0 #12468

Closed
wants to merge 1 commit into from
Closed

Bump commercial to 22.1.0 #12468

wants to merge 1 commit into from

Conversation

Jakeii
Copy link
Member

@Jakeii Jakeii commented Sep 27, 2024 •
edited
Loading

What does this change?

Bump commercial to 22.1.0 changelog here https://github.com/guardian/commercial/blob/main/CHANGELOG.md#2210

Most relevant change would be bumping source to 8.0.0

@Jakeii Jakeii requested a review from a team as a code owner September 27, 2024 12:29
@github-actions GitHub Actions
Copy link

Deploy build 37693 of Mobile::mobile-apps-rendering to CODE

All deployment options

From guardian/actions-riff-raff.

@github-actions GitHub Actions
Copy link

Hello 👋! When you're ready to run Chromatic, please apply the run_chromatic label to this PR.

You will need to reapply the label each time you want to run Chromatic.

Click here to see the Chromatic project.

@github-actions GitHub Actions
Copy link

Deploy build 13531 of dotcom:rendering-all to CODE

All deployment options

From guardian/actions-riff-raff.

@github-actions GitHub Actions
Copy link

Size Change: +18 B (0%)

Total Size: 940 kB

ℹ️ View Unchanged
Filename Size Change
dotcom-rendering/dist/1000.client.web.********************.js 999 B 0 B
dotcom-rendering/dist/1026.client.web.********************.js 784 B 0 B
dotcom-rendering/dist/1090.client.web.********************.js 752 B 0 B
dotcom-rendering/dist/1156.client.web.********************.js 3.86 kB 0 B
dotcom-rendering/dist/1177.client.web.********************.js 3.35 kB 0 B
dotcom-rendering/dist/1344.client.web.********************.js 4.42 kB 0 B
dotcom-rendering/dist/1391.client.web.********************.js 725 B 0 B
dotcom-rendering/dist/1417.client.web.********************.js 2.27 kB 0 B
dotcom-rendering/dist/1476.client.web.********************.js 784 B 0 B
dotcom-rendering/dist/1667.client.web.********************.js 918 B 0 B
dotcom-rendering/dist/1733.client.web.********************.js 5.12 kB 0 B
dotcom-rendering/dist/1808.client.web.********************.js 3.98 kB 0 B
dotcom-rendering/dist/1888.client.web.********************.js 2.94 kB 0 B
dotcom-rendering/dist/1904.client.web.********************.js 12.6 kB +1 B (+0.01%)
dotcom-rendering/dist/193.client.web.********************.js 3.38 kB 0 B
dotcom-rendering/dist/1940.client.web.********************.js 507 B 0 B
dotcom-rendering/dist/2023.client.web.********************.js 2.93 kB 0 B
dotcom-rendering/dist/2052.client.web.********************.js 2.69 kB 0 B
dotcom-rendering/dist/2123.client.web.********************.js 619 B 0 B
dotcom-rendering/dist/2145.client.web.********************.js 2.42 kB 0 B
dotcom-rendering/dist/2182.client.web.********************.js 529 B 0 B
dotcom-rendering/dist/2249.client.web.********************.js 4.91 kB 0 B
dotcom-rendering/dist/2310.client.web.********************.js 880 B 0 B
dotcom-rendering/dist/2471.client.web.********************.js 14.5 kB 0 B
dotcom-rendering/dist/2513.client.web.********************.js 3.34 kB 0 B
dotcom-rendering/dist/267.client.web.********************.js 917 B 0 B
dotcom-rendering/dist/2786.client.web.********************.js 4.91 kB 0 B
dotcom-rendering/dist/281.client.web.********************.js 642 B 0 B
dotcom-rendering/dist/3006.client.web.********************.js 4.46 kB 0 B
dotcom-rendering/dist/3109.client.web.********************.js 803 B 0 B
dotcom-rendering/dist/3270.client.web.********************.js 7.63 kB 0 B
dotcom-rendering/dist/3304.client.web.********************.js 853 B 0 B
dotcom-rendering/dist/3466.client.web.********************.js 4.07 kB 0 B
dotcom-rendering/dist/3769.client.web.********************.js 999 B 0 B
dotcom-rendering/dist/3860.client.web.********************.js 4.29 kB 0 B
dotcom-rendering/dist/4067.client.web.********************.js 8.84 kB 0 B
dotcom-rendering/dist/408.client.web.********************.js 10 kB 0 B
dotcom-rendering/dist/4122.client.web.********************.js 1.84 kB 0 B
dotcom-rendering/dist/4149.client.web.********************.js 3.77 kB 0 B
dotcom-rendering/dist/4181.client.web.********************.js 3.83 kB 0 B
dotcom-rendering/dist/4215.client.web.********************.js 2.68 kB 0 B
dotcom-rendering/dist/4282.client.web.********************.js 685 B 0 B
dotcom-rendering/dist/4501.client.web.********************.js 4.29 kB 0 B
dotcom-rendering/dist/4628.client.web.********************.js 654 B 0 B
dotcom-rendering/dist/4749.client.web.********************.js 20.2 kB 0 B
dotcom-rendering/dist/4866.client.web.********************.js 6.29 kB +1 B (+0.02%)
dotcom-rendering/dist/4875.client.web.********************.js 157 B 0 B
dotcom-rendering/dist/488.client.web.********************.js 2.52 kB 0 B
dotcom-rendering/dist/4916.client.web.********************.js 3.67 kB 0 B
dotcom-rendering/dist/4941.client.web.********************.js 890 B 0 B
dotcom-rendering/dist/4970.client.web.********************.js 5.62 kB 0 B
dotcom-rendering/dist/5006.client.web.********************.js 2.97 kB 0 B
dotcom-rendering/dist/5072.client.web.********************.js 4.67 kB 0 B
dotcom-rendering/dist/5087.client.web.********************.js 439 B 0 B
dotcom-rendering/dist/5140.client.web.********************.js 3.41 kB 0 B
dotcom-rendering/dist/5194.client.web.********************.js 3.06 kB 0 B
dotcom-rendering/dist/525.client.web.********************.js 3.01 kB 0 B
dotcom-rendering/dist/5340.client.web.********************.js 3.28 kB 0 B
dotcom-rendering/dist/5407.client.web.********************.js 3.73 kB 0 B
dotcom-rendering/dist/5658.client.web.********************.js 750 B 0 B
dotcom-rendering/dist/5757.client.web.********************.js 931 B 0 B
dotcom-rendering/dist/5880.client.web.********************.js 828 B 0 B
dotcom-rendering/dist/6044.client.web.********************.js 726 B 0 B
dotcom-rendering/dist/6071.client.web.********************.js 577 B 0 B
dotcom-rendering/dist/6135.client.web.********************.js 779 B 0 B
dotcom-rendering/dist/614.client.web.********************.js 19.2 kB 0 B
dotcom-rendering/dist/6332.client.web.********************.js 3.42 kB 0 B
dotcom-rendering/dist/6505.client.web.********************.js 1 kB 0 B
dotcom-rendering/dist/6596.client.web.********************.js 2.68 kB 0 B
dotcom-rendering/dist/6598.client.web.********************.js 780 B 0 B
dotcom-rendering/dist/6638.client.web.********************.js 907 B 0 B
dotcom-rendering/dist/678.client.web.********************.js 804 B 0 B
dotcom-rendering/dist/682.client.web.********************.js 2.99 kB 0 B
dotcom-rendering/dist/6915.client.web.********************.js 22.7 kB 0 B
dotcom-rendering/dist/7072.client.web.********************.js 3.83 kB 0 B
dotcom-rendering/dist/7116.client.web.********************.js 23 kB 0 B
dotcom-rendering/dist/7331.client.web.********************.js 4.66 kB 0 B
dotcom-rendering/dist/7341.client.web.********************.js 4.02 kB 0 B
dotcom-rendering/dist/735.client.web.********************.js 5.8 kB 0 B
dotcom-rendering/dist/7407.client.web.********************.js 3.7 kB 0 B
dotcom-rendering/dist/7691.client.web.********************.js 853 B 0 B
dotcom-rendering/dist/7780.client.web.********************.js 2.08 kB 0 B
dotcom-rendering/dist/8235.client.web.********************.js 9.86 kB 0 B
dotcom-rendering/dist/83.client.web.********************.js 750 B 0 B
dotcom-rendering/dist/8300.client.web.********************.js 3.4 kB 0 B
dotcom-rendering/dist/840.client.web.********************.js 3.21 kB 0 B
dotcom-rendering/dist/8504.client.web.********************.js 827 B 0 B
dotcom-rendering/dist/8506.client.web.********************.js 4.05 kB 0 B
dotcom-rendering/dist/8536.client.web.********************.js 595 B 0 B
dotcom-rendering/dist/8626.client.web.********************.js 890 B 0 B
dotcom-rendering/dist/8690.client.web.********************.js 3.78 kB 0 B
dotcom-rendering/dist/8697.client.web.********************.js 956 B 0 B
dotcom-rendering/dist/8746.client.web.********************.js 3.03 kB 0 B
dotcom-rendering/dist/8822.client.web.********************.js 526 B 0 B
dotcom-rendering/dist/8833.client.web.********************.js 829 B 0 B
dotcom-rendering/dist/8886.client.web.********************.js 4.57 kB 0 B
dotcom-rendering/dist/889.client.web.********************.js 961 B 0 B
dotcom-rendering/dist/8991.client.web.********************.js 4.88 kB 0 B
dotcom-rendering/dist/9132.client.web.********************.js 4.16 kB 0 B
dotcom-rendering/dist/9184.client.web.********************.js 493 B 0 B
dotcom-rendering/dist/9198.client.web.********************.js 3.58 kB 0 B
dotcom-rendering/dist/9205.client.web.********************.js 2.9 kB 0 B
dotcom-rendering/dist/9375.client.web.********************.js 4.51 kB 0 B
dotcom-rendering/dist/9493.client.web.********************.js 785 B 0 B
dotcom-rendering/dist/9557.client.web.********************.js 921 B 0 B
dotcom-rendering/dist/9669.client.web.********************.js 6.41 kB 0 B
dotcom-rendering/dist/9721.client.web.********************.js 717 B 0 B
dotcom-rendering/dist/9736.client.web.********************.js 44.2 kB 0 B
dotcom-rendering/dist/9835.client.web.********************.js 647 B 0 B
dotcom-rendering/dist/9867.client.web.********************.js 6.7 kB 0 B
dotcom-rendering/dist/9899.client.web.********************.js 669 B 0 B
dotcom-rendering/dist/Accessibility-importable.client.web.********************.js 7.92 kB 0 B
dotcom-rendering/dist/AdBlockAsk-importable.client.web.********************.js 2.85 kB 0 B
dotcom-rendering/dist/AdPortals-importable.client.web.********************.js 3.94 kB 0 B
dotcom-rendering/dist/AlreadyVisited-importable.client.web.********************.js 424 B 0 B
dotcom-rendering/dist/AppsEpic-importable.client.web.********************.js 3.57 kB 0 B
dotcom-rendering/dist/AppsFooter-importable.client.web.********************.js 3.66 kB 0 B
dotcom-rendering/dist/AppsLightboxImage-importable.client.web.********************.js 3.06 kB 0 B
dotcom-rendering/dist/AppsLightboxImageStore-importable.client.web.********************.js 2.5 kB 0 B
dotcom-rendering/dist/AudioAtomWrapper-importable.client.web.********************.js 3.58 kB 0 B
dotcom-rendering/dist/AustralianTerritorySwitcher-importable.client.web.********************.js 4.89 kB 0 B
dotcom-rendering/dist/Branding-importable.client.web.********************.js 3.05 kB 0 B
dotcom-rendering/dist/braze-web-sdk-core.client.web.********************.js 37.2 kB 0 B
dotcom-rendering/dist/BrazeMessaging-importable.client.web.********************.js 1.96 kB 0 B
dotcom-rendering/dist/CalloutBlockComponent-importable.client.web.********************.js 6.7 kB 0 B
dotcom-rendering/dist/CalloutEmbedBlockComponent-importable.client.web.********************.js 7.44 kB 0 B
dotcom-rendering/dist/CardCommentCount-importable.client.web.********************.js 3.48 kB 0 B
dotcom-rendering/dist/Carousel-importable.client.web.********************.js 7.24 kB 0 B
dotcom-rendering/dist/CarouselForNewsletters-importable.client.web.********************.js 4.5 kB 0 B
dotcom-rendering/dist/ChartAtom-importable.client.web.********************.js 541 B 0 B
dotcom-rendering/dist/CommentCount-importable.client.web.********************.js 3.3 kB 0 B
dotcom-rendering/dist/DiscussionApps-importable.client.web.********************.js 1.91 kB 0 B
dotcom-rendering/dist/DiscussionMeta-importable.client.web.********************.js 1.22 kB 0 B
dotcom-rendering/dist/DiscussionWeb-importable.client.web.********************.js 1.74 kB 0 B
dotcom-rendering/dist/DocumentBlockComponent-importable.client.web.********************.js 3.63 kB 0 B
dotcom-rendering/dist/Dropdown-importable.client.web.********************.js 1.74 kB 0 B
dotcom-rendering/dist/EditionSwitcherBanner-importable.client.web.********************.js 5.96 kB 0 B
dotcom-rendering/dist/EmbedBlockComponent-importable.client.web.********************.js 4.25 kB 0 B
dotcom-rendering/dist/EnhancePinnedPost-importable.client.web.********************.js 2.01 kB 0 B
dotcom-rendering/dist/FetchOnwardsData-importable.client.web.********************.js 2.44 kB 0 B
dotcom-rendering/dist/FilterKeyEventsToggle-importable.client.web.********************.js 969 B 0 B
dotcom-rendering/dist/FocusStyles-importable.client.web.********************.js 619 B 0 B
dotcom-rendering/dist/FollowWrapper-importable.client.web.********************.js 763 B 0 B
dotcom-rendering/dist/FooterLabel-importable.client.web.********************.js 347 B 0 B
dotcom-rendering/dist/FooterReaderRevenueLinks-importable.client.web.********************.js 3.74 kB 0 B
dotcom-rendering/dist/frameworks.client.web.********************.js 20.9 kB 0 B
dotcom-rendering/dist/FrontSubNav-importable.client.web.********************.js 5.46 kB 0 B
dotcom-rendering/dist/GetCricketScoreboard-importable.client.web.********************.js 3.82 kB 0 B
dotcom-rendering/dist/GetMatchNav-importable.client.web.********************.js 10.4 kB 0 B
dotcom-rendering/dist/GetMatchStats-importable.client.web.********************.js 7.89 kB 0 B
dotcom-rendering/dist/GetMatchTabs-importable.client.web.********************.js 2.71 kB 0 B
dotcom-rendering/dist/guardian-braze-components-banner.client.web.********************.js 17.3 kB 0 B
dotcom-rendering/dist/guardian-braze-components-end-of-article.client.web.********************.js 11.6 kB 0 B
dotcom-rendering/dist/GuideAtomWrapper-importable.client.web.********************.js 3.01 kB 0 B
dotcom-rendering/dist/HighlightsContainer-importable.client.web.********************.js 4.99 kB 0 B
dotcom-rendering/dist/index.client.web.********************.js 45.6 kB +19 B (+0.04%)
dotcom-rendering/dist/InstagramBlockComponent-importable.client.web.********************.js 3.28 kB 0 B
dotcom-rendering/dist/InteractiveAtomMessenger-importable.client.web.********************.js 849 B 0 B
dotcom-rendering/dist/InteractiveBlockComponent-importable.client.web.********************.js 6.33 kB 0 B
dotcom-rendering/dist/InteractiveContentsBlockComponent-importable.client.web.********************.js 4.72 kB 0 B
dotcom-rendering/dist/KeyEventsCarousel-importable.client.web.********************.js 4.76 kB 0 B
dotcom-rendering/dist/KnowledgeQuizAtom-importable.client.web.********************.js 3.56 kB 0 B
dotcom-rendering/dist/LatestLinks-importable.client.web.********************.js 4.89 kB 0 B
dotcom-rendering/dist/LightboxHash-importable.client.web.********************.js 436 B 0 B
dotcom-rendering/dist/LightboxLayout-importable.client.web.********************.js 6.49 kB 0 B
dotcom-rendering/dist/LiveBlogEpic-importable.client.web.********************.js 3.78 kB 0 B
dotcom-rendering/dist/LiveblogNotifications-importable.client.web.********************.js 3.15 kB 0 B
dotcom-rendering/dist/Liveness-importable.client.web.********************.js 5.51 kB 0 B
dotcom-rendering/dist/ManyNewsletterSignUp-importable.client.web.********************.js 7.84 kB 0 B
dotcom-rendering/dist/MapEmbedBlockComponent-importable.client.web.********************.js 5.44 kB 0 B
dotcom-rendering/dist/Metrics-importable.client.web.********************.js 2.69 kB -2 B (-0.07%)
dotcom-rendering/dist/MostViewedFooter-importable.client.web.********************.js 5.72 kB 0 B
dotcom-rendering/dist/MostViewedFooterData-importable.client.web.********************.js 8.35 kB 0 B
dotcom-rendering/dist/MostViewedRightWithAd-importable.client.web.********************.js 4.72 kB +1 B (+0.02%)
dotcom-rendering/dist/OnwardsUpper-importable.client.web.********************.js 5.83 kB 0 B
dotcom-rendering/dist/PersonalityQuizAtom-importable.client.web.********************.js 3.71 kB 0 B
dotcom-rendering/dist/ProfileAtom-importable.client.web.********************.js 2.8 kB 0 B
dotcom-rendering/dist/ProfileAtomWrapper-importable.client.web.********************.js 3.03 kB 0 B
dotcom-rendering/dist/PulsingDot-importable.client.web.********************.js 750 B 0 B
dotcom-rendering/dist/QandaAtom-importable.client.web.********************.js 2.79 kB 0 B
dotcom-rendering/dist/ReaderRevenueDev-importable.client.web.********************.js 469 B 0 B
dotcom-rendering/dist/readerRevenueDevUtils.client.web.********************.js 1.97 kB 0 B
dotcom-rendering/dist/RelativeTime-importable.client.web.********************.js 2.53 kB 0 B
dotcom-rendering/dist/RichLinkComponent-importable.client.web.********************.js 5.21 kB 0 B
dotcom-rendering/dist/SecureSignup-importable.client.web.********************.js 5.11 kB 0 B
dotcom-rendering/dist/SendTargetingParams-importable.client.web.********************.js 2.19 kB 0 B
dotcom-rendering/dist/sentry.client.web.********************.js 792 B 0 B
dotcom-rendering/dist/SetABTests-importable.client.web.********************.js 3.69 kB 0 B
dotcom-rendering/dist/SetAdTargeting-importable.client.web.********************.js 484 B 0 B
dotcom-rendering/dist/ShareButton-importable.client.web.********************.js 1.53 kB 0 B
dotcom-rendering/dist/shimport.client.web.********************.js 2.8 kB 0 B
dotcom-rendering/dist/ShowHideContainers-importable.client.web.********************.js 644 B 0 B
dotcom-rendering/dist/ShowMore-importable.client.web.********************.js 5.7 kB 0 B
dotcom-rendering/dist/SignInGateMain.client.web.********************.js 4.54 kB 0 B
dotcom-rendering/dist/SignInGateMainCheckoutComplete.client.web.********************.js 3.93 kB 0 B
dotcom-rendering/dist/SignInGateSelector-importable.client.web.********************.js 3.16 kB 0 B
dotcom-rendering/dist/SlotBodyEnd-importable.client.web.********************.js 3.48 kB -2 B (-0.06%)
dotcom-rendering/dist/SpotifyBlockComponent-importable.client.web.********************.js 5.3 kB 0 B
dotcom-rendering/dist/StickyBottomBanner-importable.client.web.********************.js 4.2 kB 0 B
dotcom-rendering/dist/StickyLiveblogAskWrapper-importable.client.web.********************.js 7.66 kB 0 B
dotcom-rendering/dist/SubNav-importable.client.web.********************.js 3.41 kB 0 B
dotcom-rendering/dist/TableOfContents-importable.client.web.********************.js 3.19 kB 0 B
dotcom-rendering/dist/TimelineAtom-importable.client.web.********************.js 3.22 kB 0 B
dotcom-rendering/dist/Titlepiece-importable.client.web.********************.js 14.7 kB 0 B
dotcom-rendering/dist/TopBar-importable.client.web.********************.js 8.26 kB 0 B
dotcom-rendering/dist/TopBarSupport-importable.client.web.********************.js 2.75 kB 0 B
dotcom-rendering/dist/TweetBlockComponent-importable.client.web.********************.js 1.13 kB 0 B
dotcom-rendering/dist/UnsafeEmbedBlockComponent-importable.client.web.********************.js 3.29 kB 0 B
dotcom-rendering/dist/VideoFacebookBlockComponent-importable.client.web.********************.js 5.45 kB 0 B
dotcom-rendering/dist/VineBlockComponent-importable.client.web.********************.js 3.11 kB 0 B
dotcom-rendering/dist/WeatherWrapper-importable.client.web.********************.js 7.06 kB 0 B
dotcom-rendering/dist/YoutubeBlockComponent-importable.client.web.********************.js 3.94 kB 0 B

compressed-size-action

@Jakeii Jakeii added the run_chromatic Runs chromatic when label is applied label Sep 27, 2024
@github-actions github-actions bot removed the run_chromatic Runs chromatic when label is applied label Sep 27, 2024
@jamesmockett
Copy link
Contributor

Unless there's an immediate need for this it might be better to add the version bump to the Source PR (#12342) to avoid a peer dependency mismatch? That way Source, commercial and braze-components will all get bumped at the same time and have matching peer dependencies.

@Jakeii
Copy link
Member Author

Jakeii commented Sep 27, 2024

@jamesmockett Sounds good, can I leave that to you?

@jamesmockett
Copy link
Contributor

@jamesmockett Sounds good, can I leave that to you?

No worries. It's 10% time today and it's probably not a good thing to try and merge before the weekend as it includes lots of changes, but hopefully we'll get it in on Monday.

@Jakeii
Copy link
Member Author

Jakeii commented Sep 27, 2024

closing in favour of #12342

@Jakeii Jakeii closed this Sep 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@deedeeh deedeeh deedeeh approved these changes

Assignees
No one assigned
Labels
dotcom-rendering
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Jakeii @jamesmockett @deedeeh