-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reduce number of instances used for rendering
app
#10395
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hello 👋! When you're ready to run Chromatic, please apply the |
Size Change: 0 B Total Size: 750 kB ℹ️ View Unchanged
|
georgeblahblah
approved these changes
Jan 29, 2024
mxdvl
approved these changes
Jan 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this change?
Reduces the number of instances from 27 down to 18 for the
rendering
app (DotcomRendering
in CDK), now that most of the traffic has been diverted to thearticle-rendering
app (RenderingCDKStack
in CDK).Also reduces the maximum number of instances from 120 down to 80.
Why?
We don't need as many instances as we're using.
We also want to see if it will even improve performance as there's a theory that spreading the traffic across so many instances means that we are experiencing slow starts from each instance running the application.
Resolves #10396