Parse Comment & Abuse responses of the Discussion API #10364

mxdvl · 2024-01-26T17:22:14Z

What does this change?

Parse the API response for comment being posted.

Why?

Eeduce the complexity of the possible responses

Part of #8745

Screenshots

Identical

github-actions · 2024-01-26T17:22:54Z

Deploy build 31335 of `Mobile::mobile-apps-rendering` to CODE

All deployment options

From guardian/actions-riff-raff.

github-actions · 2024-01-26T17:26:54Z

Size Change: +672 B (0%)

Total Size: 750 kB

Filename	Size	Change
`dotcom-rendering/dist/2132.client.web.********************.js`	5.09 kB	+204 B (+4%)
`dotcom-rendering/dist/DiscussionContainer-importable.client.web.********************.js`	23.5 kB	+468 B (+2%)

ℹ️ View Unchanged

Filename	Size
`dotcom-rendering/dist/11.client.web.********************.js`	5.78 kB
`dotcom-rendering/dist/112.client.web.********************.js`	823 B
`dotcom-rendering/dist/1191.client.web.********************.js`	679 B
`dotcom-rendering/dist/1229.client.web.********************.js`	8.67 kB
`dotcom-rendering/dist/1407.client.web.********************.js`	639 B
`dotcom-rendering/dist/1412.client.web.********************.js`	4.31 kB
`dotcom-rendering/dist/1459.client.web.********************.js`	877 B
`dotcom-rendering/dist/1749.client.web.********************.js`	920 B
`dotcom-rendering/dist/1955.client.web.********************.js`	4.71 kB
`dotcom-rendering/dist/2276.client.web.********************.js`	3.35 kB
`dotcom-rendering/dist/2293.client.web.********************.js`	581 B
`dotcom-rendering/dist/307.client.web.********************.js`	13.2 kB
`dotcom-rendering/dist/3314.client.web.********************.js`	4.76 kB
`dotcom-rendering/dist/3375.client.web.********************.js`	2.7 kB
`dotcom-rendering/dist/3410.client.web.********************.js`	2.68 kB
`dotcom-rendering/dist/3889.client.web.********************.js`	8.24 kB
`dotcom-rendering/dist/393.client.web.********************.js`	921 B
`dotcom-rendering/dist/3958.client.web.********************.js`	39.9 kB
`dotcom-rendering/dist/3986.client.web.********************.js`	496 B
`dotcom-rendering/dist/4002.client.web.********************.js`	4.59 kB
`dotcom-rendering/dist/4040.client.web.********************.js`	651 B
`dotcom-rendering/dist/4045.client.web.********************.js`	642 B
`dotcom-rendering/dist/405.client.web.********************.js`	915 B
`dotcom-rendering/dist/4215.client.web.********************.js`	409 B
`dotcom-rendering/dist/4219.client.web.********************.js`	5.74 kB
`dotcom-rendering/dist/4265.client.web.********************.js`	2.38 kB
`dotcom-rendering/dist/4269.client.web.********************.js`	667 B
`dotcom-rendering/dist/4298.client.web.********************.js`	8.41 kB
`dotcom-rendering/dist/4390.client.web.********************.js`	507 B
`dotcom-rendering/dist/4438.client.web.********************.js`	802 B
`dotcom-rendering/dist/4442.client.web.********************.js`	712 B
`dotcom-rendering/dist/478.client.web.********************.js`	594 B
`dotcom-rendering/dist/4870.client.web.********************.js`	747 B
`dotcom-rendering/dist/4911.client.web.********************.js`	780 B
`dotcom-rendering/dist/4982.client.web.********************.js`	3.82 kB
`dotcom-rendering/dist/5020.client.web.********************.js`	994 B
`dotcom-rendering/dist/5041.client.web.********************.js`	3.76 kB
`dotcom-rendering/dist/5047.client.web.********************.js`	779 B
`dotcom-rendering/dist/5144.client.web.********************.js`	5.08 kB
`dotcom-rendering/dist/5242.client.web.********************.js`	529 B
`dotcom-rendering/dist/5290.client.web.********************.js`	3.24 kB
`dotcom-rendering/dist/5499.client.web.********************.js`	2.47 kB
`dotcom-rendering/dist/5619.client.web.********************.js`	926 B
`dotcom-rendering/dist/5730.client.web.********************.js`	954 B
`dotcom-rendering/dist/5772.client.web.********************.js`	9.97 kB
`dotcom-rendering/dist/5957.client.web.********************.js`	5.93 kB
`dotcom-rendering/dist/5985.client.web.********************.js`	748 B
`dotcom-rendering/dist/6043.client.web.********************.js`	852 B
`dotcom-rendering/dist/6140.client.web.********************.js`	852 B
`dotcom-rendering/dist/6651.client.web.********************.js`	905 B
`dotcom-rendering/dist/6693.client.web.********************.js`	823 B
`dotcom-rendering/dist/6756.client.web.********************.js`	525 B
`dotcom-rendering/dist/6853.client.web.********************.js`	1 kB
`dotcom-rendering/dist/7018.client.web.********************.js`	787 B
`dotcom-rendering/dist/7167.client.web.********************.js`	16.5 kB
`dotcom-rendering/dist/7329.client.web.********************.js`	2.77 kB
`dotcom-rendering/dist/7356.client.web.********************.js`	1 kB
`dotcom-rendering/dist/7554.client.web.********************.js`	3.27 kB
`dotcom-rendering/dist/7629.client.web.********************.js`	2.87 kB
`dotcom-rendering/dist/7855.client.web.********************.js`	787 B
`dotcom-rendering/dist/7983.client.web.********************.js`	3.1 kB
`dotcom-rendering/dist/8002.client.web.********************.js`	801 B
`dotcom-rendering/dist/8113.client.web.********************.js`	3.48 kB
`dotcom-rendering/dist/8288.client.web.********************.js`	23 kB
`dotcom-rendering/dist/8310.client.web.********************.js`	3.74 kB
`dotcom-rendering/dist/8344.client.web.********************.js`	1.56 kB
`dotcom-rendering/dist/8388.client.web.********************.js`	618 B
`dotcom-rendering/dist/841.client.web.********************.js`	788 B
`dotcom-rendering/dist/8784.client.web.********************.js`	5.09 kB
`dotcom-rendering/dist/8818.client.web.********************.js`	746 B
`dotcom-rendering/dist/8937.client.web.********************.js`	888 B
`dotcom-rendering/dist/9004.client.web.********************.js`	5.85 kB
`dotcom-rendering/dist/9106.client.web.********************.js`	2.93 kB
`dotcom-rendering/dist/9173.client.web.********************.js`	724 B
`dotcom-rendering/dist/9314.client.web.********************.js`	823 B
`dotcom-rendering/dist/9343.client.web.********************.js`	2.98 kB
`dotcom-rendering/dist/9458.client.web.********************.js`	4.82 kB
`dotcom-rendering/dist/9529.client.web.********************.js`	3.24 kB
`dotcom-rendering/dist/958.client.web.********************.js`	3.17 kB
`dotcom-rendering/dist/9591.client.web.********************.js`	1.85 kB
`dotcom-rendering/dist/9621.client.web.********************.js`	719 B
`dotcom-rendering/dist/9676.client.web.********************.js`	888 B
`dotcom-rendering/dist/9856.client.web.********************.js`	5.75 kB
`dotcom-rendering/dist/9879.client.web.********************.js`	3.38 kB
`dotcom-rendering/dist/9978.client.web.********************.js`	960 B
`dotcom-rendering/dist/AdPortals-importable.client.web.********************.js`	3.72 kB
`dotcom-rendering/dist/AlreadyVisited-importable.client.web.********************.js`	425 B
`dotcom-rendering/dist/AppsEpic-importable.client.web.********************.js`	4.09 kB
`dotcom-rendering/dist/AppsFooter-importable.client.web.********************.js`	3.57 kB
`dotcom-rendering/dist/AppsLightboxImage-importable.client.web.********************.js`	3 kB
`dotcom-rendering/dist/AppsLightboxImageStore-importable.client.web.********************.js`	2.42 kB
`dotcom-rendering/dist/AudioAtomWrapper-importable.client.web.********************.js`	3.58 kB
`dotcom-rendering/dist/AustralianTerritorySwitcher-importable.client.web.********************.js`	2.01 kB
`dotcom-rendering/dist/Branding-importable.client.web.********************.js`	2.54 kB
`dotcom-rendering/dist/braze-web-sdk-core.client.web.********************.js`	36.9 kB
`dotcom-rendering/dist/BrazeMessaging-importable.client.web.********************.js`	5.26 kB
`dotcom-rendering/dist/CalloutBlockComponent-importable.client.web.********************.js`	6.75 kB
`dotcom-rendering/dist/CalloutEmbedBlockComponent-importable.client.web.********************.js`	5.76 kB
`dotcom-rendering/dist/CardCommentCount-importable.client.web.********************.js`	4.43 kB
`dotcom-rendering/dist/Carousel-importable.client.web.********************.js`	5.52 kB
`dotcom-rendering/dist/CarouselForNewsletters-importable.client.web.********************.js`	5.65 kB
`dotcom-rendering/dist/ChartAtom-importable.client.web.********************.js`	541 B
`dotcom-rendering/dist/CommentCount-importable.client.web.********************.js`	3.24 kB
`dotcom-rendering/dist/DiscussionMeta-importable.client.web.********************.js`	4.01 kB
`dotcom-rendering/dist/DocumentBlockComponent-importable.client.web.********************.js`	3.57 kB
`dotcom-rendering/dist/EmbedBlockComponent-importable.client.web.********************.js`	4.13 kB
`dotcom-rendering/dist/EnhancePinnedPost-importable.client.web.********************.js`	2.01 kB
`dotcom-rendering/dist/FetchOnwardsData-importable.client.web.********************.js`	2.55 kB
`dotcom-rendering/dist/FilterKeyEventsToggle-importable.client.web.********************.js`	3.35 kB
`dotcom-rendering/dist/FocusStyles-importable.client.web.********************.js`	609 B
`dotcom-rendering/dist/FollowWrapper-importable.client.web.********************.js`	789 B
`dotcom-rendering/dist/FooterLabel-importable.client.web.********************.js`	341 B
`dotcom-rendering/dist/frameworks.client.web.********************.js`	20.7 kB
`dotcom-rendering/dist/GetCricketScoreboard-importable.client.web.********************.js`	3.76 kB
`dotcom-rendering/dist/GetMatchNav-importable.client.web.********************.js`	10.7 kB
`dotcom-rendering/dist/GetMatchStats-importable.client.web.********************.js`	1.63 kB
`dotcom-rendering/dist/GetMatchTabs-importable.client.web.********************.js`	2.62 kB
`dotcom-rendering/dist/guardian-braze-components-banner.client.web.********************.js`	14.7 kB
`dotcom-rendering/dist/guardian-braze-components-end-of-article.client.web.********************.js`	9.29 kB
`dotcom-rendering/dist/GuideAtomWrapper-importable.client.web.********************.js`	781 B
`dotcom-rendering/dist/HeaderTopBar-importable.client.web.********************.js`	10.9 kB
`dotcom-rendering/dist/index.client.web.********************.js`	47.2 kB
`dotcom-rendering/dist/InstagramBlockComponent-importable.client.web.********************.js`	3.67 kB
`dotcom-rendering/dist/InteractiveBlockComponent-importable.client.web.********************.js`	6.09 kB
`dotcom-rendering/dist/InteractiveContentsBlockComponent-importable.client.web.********************.js`	4.66 kB
`dotcom-rendering/dist/InteractiveSupportButton-importable.client.web.********************.js`	3.45 kB
`dotcom-rendering/dist/KeyEventsCarousel-importable.client.web.********************.js`	4.55 kB
`dotcom-rendering/dist/KnowledgeQuizAtom-importable.client.web.********************.js`	3.54 kB
`dotcom-rendering/dist/LatestLinks-importable.client.web.********************.js`	2.13 kB
`dotcom-rendering/dist/LightboxHash-importable.client.web.********************.js`	433 B
`dotcom-rendering/dist/LightboxLayout-importable.client.web.********************.js`	6.46 kB
`dotcom-rendering/dist/LiveBlogEpic-importable.client.web.********************.js`	3.59 kB
`dotcom-rendering/dist/Liveness-importable.client.web.********************.js`	4.93 kB
`dotcom-rendering/dist/ManyNewsletterSignUp-importable.client.web.********************.js`	6.61 kB
`dotcom-rendering/dist/MapEmbedBlockComponent-importable.client.web.********************.js`	5.66 kB
`dotcom-rendering/dist/Metrics-importable.client.web.********************.js`	2.29 kB
`dotcom-rendering/dist/MostViewedFooter-importable.client.web.********************.js`	4.04 kB
`dotcom-rendering/dist/MostViewedFooterData-importable.client.web.********************.js`	6.74 kB
`dotcom-rendering/dist/MostViewedRightWrapper-importable.client.web.********************.js`	4.45 kB
`dotcom-rendering/dist/OnwardsUpper-importable.client.web.********************.js`	4.26 kB
`dotcom-rendering/dist/PersonalityQuizAtom-importable.client.web.********************.js`	3.65 kB
`dotcom-rendering/dist/ProfileAtom-importable.client.web.********************.js`	543 B
`dotcom-rendering/dist/ProfileAtomWrapper-importable.client.web.********************.js`	802 B
`dotcom-rendering/dist/PulsingDot-importable.client.web.********************.js`	749 B
`dotcom-rendering/dist/QandaAtom-importable.client.web.********************.js`	539 B
`dotcom-rendering/dist/ReaderRevenueDev-importable.client.web.********************.js`	470 B
`dotcom-rendering/dist/readerRevenueDevUtils.client.web.********************.js`	1.89 kB
`dotcom-rendering/dist/ReaderRevenueLinks-importable.client.web.********************.js`	5.77 kB
`dotcom-rendering/dist/RelativeTime-importable.client.web.********************.js`	1.99 kB
`dotcom-rendering/dist/RichLinkComponent-importable.client.web.********************.js`	6.21 kB
`dotcom-rendering/dist/SecureSignup-importable.client.web.********************.js`	3.5 kB
`dotcom-rendering/dist/SendAMessage-importable.client.web.********************.js`	4.39 kB
`dotcom-rendering/dist/SendTargetingParams-importable.client.web.********************.js`	2.11 kB
`dotcom-rendering/dist/sentry.client.web.********************.js`	771 B
`dotcom-rendering/dist/SetABTests-importable.client.web.********************.js`	3.37 kB
`dotcom-rendering/dist/SetAdTargeting-importable.client.web.********************.js`	481 B
`dotcom-rendering/dist/shimport.client.web.********************.js`	2.79 kB
`dotcom-rendering/dist/ShowHideContainers-importable.client.web.********************.js`	646 B
`dotcom-rendering/dist/ShowMore-importable.client.web.********************.js`	5.71 kB
`dotcom-rendering/dist/SignInGateMain.client.web.********************.js`	3.9 kB
`dotcom-rendering/dist/SignInGateMainCheckoutComplete.client.web.********************.js`	5 kB
`dotcom-rendering/dist/SignInGateSelector-importable.client.web.********************.js`	5.63 kB
`dotcom-rendering/dist/SlotBodyEnd-importable.client.web.********************.js`	6.83 kB
`dotcom-rendering/dist/SpotifyBlockComponent-importable.client.web.********************.js`	5.49 kB
`dotcom-rendering/dist/StickyBottomBanner-importable.client.web.********************.js`	5.37 kB
`dotcom-rendering/dist/SubNav-importable.client.web.********************.js`	2.24 kB
`dotcom-rendering/dist/SupportTheG-importable.client.web.********************.js`	5.89 kB
`dotcom-rendering/dist/TableOfContents-importable.client.web.********************.js`	3.1 kB
`dotcom-rendering/dist/TimelineAtom-importable.client.web.********************.js`	1.24 kB
`dotcom-rendering/dist/TweetBlockComponent-importable.client.web.********************.js`	1.02 kB
`dotcom-rendering/dist/UnsafeEmbedBlockComponent-importable.client.web.********************.js`	3.68 kB
`dotcom-rendering/dist/VideoFacebookBlockComponent-importable.client.web.********************.js`	5.66 kB
`dotcom-rendering/dist/VineBlockComponent-importable.client.web.********************.js`	3.51 kB
`dotcom-rendering/dist/WeatherWrapper-importable.client.web.********************.js`	5.45 kB
`dotcom-rendering/dist/YoutubeBlockComponent-importable.client.web.********************.js`	3.9 kB

_{compressed-size-action}

dotcom-rendering/src/types/discussion.ts

JamieB-gu · 2024-01-26T18:16:50Z

dotcom-rendering/src/types/discussion.ts

+const errorCodes = [
+	'USERNAME_MISSING',
+	'EMPTY_COMMENT_BODY',
+	'COMMENT_TOO_LONG',
+	'USER_BANNED',
+	'IP_THROTTLED',
+	'DISCUSSION_CLOSED',
+	'PARENT_COMMENT_MODERATED',
+	'COMMENT_RATE_LIMIT_EXCEEDED',
+	'INVALID_PROTOCOL',
+	'AUTH_COOKIE_INVALID',
+	'READ-ONLY-MODE',
+	'API_CORS_BLOCKED',
+	'API_ERROR',
+	'EMAIL_VERIFIED',
+	'EMAIL_VERIFIED_FAIL',
+	'EMAIL_NOT_VALIDATED',
+] as const;


There’s actually a lot more, but we’re not responding to them in any meaningful way

reduce the complexity of the possible types, and remove any unused parts of the API response

github-actions · 2024-01-26T18:54:44Z

Deploy build 46154 of `dotcom:rendering` to CODE

All deployment options

From guardian/actions-riff-raff.

github-actions · 2024-01-26T18:54:50Z

Deploy build 7294 of `dotcom:rendering-all` to CODE

All deployment options

From guardian/actions-riff-raff.

Co-authored-by: Jamie B <[email protected]>

prout-bot · 2024-01-29T09:35:12Z

Seen on PROD (merged by @mxdvl 7 minutes and 55 seconds ago) Please check your changes!

mxdvl requested a review from a team as a code owner January 26, 2024 17:22

github-actions bot added the dotcom-rendering label Jan 26, 2024

JamieB-gu approved these changes Jan 26, 2024

View reviewed changes

feat(discussion): parse comment & abuse responses

7aed973

reduce the complexity of the possible types, and remove any unused parts of the API response

mxdvl force-pushed the mxdvl/discussion/more-validation branch from d7e7f9c to 7aed973 Compare January 26, 2024 18:49

mxdvl changed the title ~~feat(discussionApi): parse CommentResponse~~ Parse Comment & Abuse responses of the Discussion API Jan 26, 2024

fix(comment): ensure number is integer

9641ca5

Co-authored-by: Jamie B <[email protected]>

mxdvl added the run_chromatic Runs chromatic when label is applied label Jan 29, 2024

mxdvl merged commit 9366a72 into main Jan 29, 2024
28 checks passed

mxdvl deleted the mxdvl/discussion/more-validation branch January 29, 2024 09:27

prout-bot added Pending-on-PROD Seen-on-PROD and removed Pending-on-PROD labels Jan 29, 2024

mxdvl mentioned this pull request Jan 29, 2024

Parsing discussion API responses #10369

Closed

mxdvl added this to the DCR for Apps milestone May 30, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Parse Comment & Abuse responses of the Discussion API #10364

Parse Comment & Abuse responses of the Discussion API #10364

mxdvl commented Jan 26, 2024

github-actions bot commented Jan 26, 2024 •

edited

Loading

github-actions bot commented Jan 26, 2024 •

edited

Loading

JamieB-gu Jan 26, 2024

mxdvl Jan 26, 2024

github-actions bot commented Jan 26, 2024 •

edited

Loading

github-actions bot commented Jan 26, 2024 •

edited

Loading

prout-bot commented Jan 29, 2024

Parse Comment & Abuse responses of the Discussion API #10364

Parse Comment & Abuse responses of the Discussion API #10364

Conversation

mxdvl commented Jan 26, 2024

What does this change?

Why?

Screenshots

github-actions bot commented Jan 26, 2024 • edited Loading

Deploy build 31335 of Mobile::mobile-apps-rendering to CODE

github-actions bot commented Jan 26, 2024 • edited Loading

JamieB-gu Jan 26, 2024

Choose a reason for hiding this comment

mxdvl Jan 26, 2024

Choose a reason for hiding this comment

github-actions bot commented Jan 26, 2024 • edited Loading

Deploy build 46154 of dotcom:rendering to CODE

github-actions bot commented Jan 26, 2024 • edited Loading

Deploy build 7294 of dotcom:rendering-all to CODE

prout-bot commented Jan 29, 2024

github-actions bot commented Jan 26, 2024 •

edited

Loading

Deploy build 31335 of `Mobile::mobile-apps-rendering` to CODE

github-actions bot commented Jan 26, 2024 •

edited

Loading

github-actions bot commented Jan 26, 2024 •

edited

Loading

Deploy build 46154 of `dotcom:rendering` to CODE

github-actions bot commented Jan 26, 2024 •

edited

Loading

Deploy build 7294 of `dotcom:rendering-all` to CODE