Refactor getDiscussion
#10361
Merged
Refactor getDiscussion
#10361
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
and safer error handling See guardian/discussion-api for type definitions Co-authored-by: Jamie B <[email protected]>
mxdvl
force-pushed
the
discussion/getDiscussion-API-refactor
branch
from
a959fb7 to
fedd1fe
Compare
|
Size Change: +543 B (0%) Total Size: 750 kB
ℹ️ View Unchanged
|
JamieB-gu
reviewed
Jan 26, 2024
| }) | ||
| .catch((e) => console.error(`getDiscussion - error: ${String(e)}`)); | ||
| .catch(() => { | ||
| // do nothing |
There was a problem hiding this comment.
I wonder if there's a way we can still allow errors to be reported? Our getDiscussion code could still crash, or the then callback here could crash, and this would suppress either of those errors?
There was a problem hiding this comment.
Good point, we should use window.guardian.sentry.reportError.
This could drastically increase the number of errors, though, so we’d want to do this in a separate PR
JamieB-gu
approved these changes
Jan 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this change?
getDiscussionResultwhich is a discriminated union with a success and failure variantfetchJSONwhich returns aResult<'ApiError' | 'NetworkError', unknown>, and allows safely deserialising any JSON from a URLWhy?
Part of #8745
Screenshots
No change (tested locally)