Ophan e2e tests and remove Ophan request cancellation #10359
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arelra
added
run_chromatic
|
Size Change: 0 B Total Size: 749 kB ℹ️ View Unchanged
|
ioannakok
reviewed
Jan 26, 2024
| }) => { | ||
| const ophanRequestPromise = interceptOphanRequest({ | ||
| page, | ||
| path: 'img/1', |
There was a problem hiding this comment.
Good question!
Looking at the network requests that Ophan makes:
img/1is the single 'view' request that conveys the page URL being viewed.img/2are the multiple 'event' requests that convey individual pieces of data such as abtests, attentionMS, consent and performance metrics.
Its good to raise though. I will ask the Ophan team what their official naming is for these requests.
ioannakok
approved these changes
Jan 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this change?
Following #10330 we can now:
img/1andimg/2requests are made to Ophan for articles and fronts including tests when consent is given or rejectedloadPageutilloadevent to ensure all requests have completed when loading pages rather thandomcontentloaded. Although this adds ~1-5s per test it should improve test stabilityWhy?
Improved test coverage