Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Investigate whether renderTime metric can be replaced with ELB checks #8811

Open
cemms1 opened this issue Sep 12, 2023 · 1 comment
Open
Labels
Pick me up small effort, self contained issues to do when you feel like a pick me up, waiting to be unblocked…
Milestone

Comments

@cemms1
Copy link
Contributor

cemms1 commented Sep 12, 2023

In our regular dashboard session for WebX, we often check the renderTime percentiles Kibana graph which uses the time taken to render a page based on logging info. This graph takes a long time to load and we aren't sure if we get much value from it.

PR which introduced logging rendering times: #2721

Permalink:

// Middleware to track route performance using 'response-time' lib
// Usage: app.post('/Article', logRenderTime, renderArticle);
const logRenderTime = responseTime(
(_1: Request, _2: Response, renderTime: number) => {
logger.info('Page render time', {
renderTime,
});
},
);

We might be duplicating efforts here as the load balancer should give us the request time for DCR. Using the data from the ELB should be much faster than checking logging information.

The result of this ticket should confirm whether or not we can remove the render time logging in favour of ELB data. If so, we should remove the chart in Kibana and remove the logging in DCR, unless we need to use it for any other reason.

@cemms1 cemms1 added this to WebX Team Sep 12, 2023
@cemms1 cemms1 added the Pick me up small effort, self contained issues to do when you feel like a pick me up, waiting to be unblocked… label Sep 12, 2023
@github-project-automation github-project-automation bot moved this to Triage in WebX Team Sep 12, 2023
@cemms1 cemms1 moved this from Triage to Backlog in WebX Team Sep 12, 2023
@jamesgorrie
Copy link
Contributor

This might make it hard to slice the data by endpoint, which has proven useful in the past.

Saying that, this may become less of an issue if we split the stacks with their own ELBs:
#8351

I'm not 100% sure what meta data get's attached to AWS logs? But pretty certain request information isn't attached.

@alinaboghiu alinaboghiu added this to the Health milestone Oct 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Pick me up small effort, self contained issues to do when you feel like a pick me up, waiting to be unblocked…
Projects
Status: Backlog
Development

No branches or pull requests

3 participants