Skip to content

Commit

Permalink
docs: add todos for next steps
Browse files Browse the repository at this point in the history
  • Loading branch information
cemms1 committed Sep 11, 2023
1 parent dfc452d commit 0528f48
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 0 deletions.
3 changes: 3 additions & 0 deletions dotcom-rendering/src/model/enhanceBlocks.ts
Original file line number Diff line number Diff line change
Expand Up @@ -96,6 +96,9 @@ type Options = {
promotedNewsletter: Newsletter | undefined;
};

// TODO - add consideration of rendering target / platform
// so that we can add app-only enhancers

// IMPORTANT: the ordering of the enhancer is IMPORTANT to keep in mind
// example: enhanceInteractiveContentElements needs to be before enhanceNumberedLists
// as they both effect SubheadingBlockElement
Expand Down
3 changes: 3 additions & 0 deletions dotcom-rendering/src/server/index.article.apps.ts
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,9 @@ import { renderArticle } from './render.article.apps';

export const handleAppsArticle: RequestHandler = ({ body }, res) => {
recordTypeAndPlatform('article', 'apps');

// TODO - add renderingTarget so that we can enhance
// blocks specifically for Apps
const article = enhanceArticleType(body);
const { html, prefetchScripts } = renderArticle(article);

Expand Down

0 comments on commit 0528f48

Please sign in to comment.