Merge pull request #9340 from guardian/olly/tag-fronts-missing-bio

Fix tag fronts that were missing a bio/description
guardian · Oct 26, 2023 · b5893aa · b5893aa
2 parents ad2a881 + f976e8d
commit b5893aa
Show file tree

Hide file tree

Showing 4 changed files with 19 additions and 1 deletion.
diff --git a/dotcom-rendering/src/model/front-schema.json b/dotcom-rendering/src/model/front-schema.json
@@ -711,6 +711,9 @@
                                                                                     "bio": {
                                                                                         "type": "string"
                                                                                     },
+                                                                                    "description": {
+                                                                                        "type": "string"
+                                                                                    },
                                                                                     "bylineImageUrl": {
                                                                                         "type": "string"
                                                                                     },
@@ -1421,6 +1424,9 @@
                                                                                     "bio": {
                                                                                         "type": "string"
                                                                                     },
+                                                                                    "description": {
+                                                                                        "type": "string"
+                                                                                    },
                                                                                     "bylineImageUrl": {
                                                                                         "type": "string"
                                                                                     },
@@ -2131,6 +2137,9 @@
                                                                                     "bio": {
                                                                                         "type": "string"
                                                                                     },
+                                                                                    "description": {
+                                                                                        "type": "string"
+                                                                                    },
                                                                                     "bylineImageUrl": {
                                                                                         "type": "string"
                                                                                     },

diff --git a/dotcom-rendering/src/model/tag-front-schema.json b/dotcom-rendering/src/model/tag-front-schema.json
@@ -225,6 +225,9 @@
                                                                 "bio": {
                                                                     "type": "string"
                                                                 },
+                                                                "description": {
+                                                                    "type": "string"
+                                                                },
                                                                 "bylineImageUrl": {
                                                                     "type": "string"
                                                                 },
@@ -738,6 +741,9 @@
                                     "bio": {
                                         "type": "string"
                                     },
+                                    "description": {
+                                        "type": "string"
+                                    },
                                     "bylineImageUrl": {
                                         "type": "string"
                                     },

diff --git a/dotcom-rendering/src/server/index.front.web.ts b/dotcom-rendering/src/server/index.front.web.ts
@@ -90,7 +90,9 @@ const enhanceTagFront = (body: unknown): DCRTagFrontType => {
 		trendingTopics: extractTrendingTopics(data.contents, data.pageId),
 		header: {
 			title: data.webTitle,
-			description: data.tags.tags[0]?.properties.bio,
+			description:
+				data.tags.tags[0]?.properties.bio ??
+				data.tags.tags[0]?.properties.description,
 			image: data.tags.tags[0]?.properties.bylineImageUrl,
 		},
 	};

diff --git a/dotcom-rendering/src/types/tag.ts b/dotcom-rendering/src/types/tag.ts
@@ -10,6 +10,7 @@ export type FETagType = {
 		webTitle: string;
 		/* bio is html */
 		bio?: string;
+		description?: string;
 		bylineImageUrl?: string;
 		bylineLargeImageUrl?: string;
 		contributorLargeImagePath?: string;