test: what if we made this optional

part of an experiment from @JamieB-gu & @alinaboghiu
guardian · Jan 25, 2024 · afc3363 · afc3363
1 parent 663b4ab
commit afc3363
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 2 deletions.
diff --git a/dotcom-rendering/src/components/Card/Card.tsx b/dotcom-rendering/src/components/Card/Card.tsx
@@ -472,7 +472,10 @@ export const Card = ({
 											defer={{ until: 'visible' }}
 										>
 											<YoutubeBlockComponent
-												id={media.mainMedia.id}
+												id={
+													media.mainMedia.id ??
+													'something-very-odd-happened-but-let-us-crack-on'
+												}
 												assetId={
 													media.mainMedia.videoId
 												}

diff --git a/dotcom-rendering/src/types/mainMedia.ts b/dotcom-rendering/src/types/mainMedia.ts
@@ -6,7 +6,7 @@ type Media = {
 type Video = Media & {
 	type: 'Video';
 	/** @see https://github.com/guardian/frontend/blob/8e7e4d0e/common/app/model/content/Atom.scala#L159 */
-	id: string;
+	id?: string;
 	videoId: string;
 	height: number;
 	width: number;