Use id from AudioBlockElement for media-id if available

guardian · Jan 7, 2025 · 0b6a262 · 0b6a262
1 parent 1a4b51b
commit 0b6a262
Show file tree

Hide file tree

Showing 4 changed files with 9 additions and 2 deletions.
diff --git a/dotcom-rendering/src/lib/audio-data.ts b/dotcom-rendering/src/lib/audio-data.ts
@@ -8,10 +8,10 @@ export const getAudioData = (
 			element._type ===
 			'model.dotcomrendering.pageElements.AudioBlockElement',
 	);
-	if (audioBlockElement?.assets[0] && audioBlockElement.elementId) {
+	if (audioBlockElement?.assets[0] && audioBlockElement.id) {
 		return {
 			audioDownloadUrl: audioBlockElement.assets[0].url,
-			mediaId: audioBlockElement.elementId,
+			mediaId: audioBlockElement.id,
 		};
 	}
 	return undefined;

diff --git a/dotcom-rendering/src/model/article-schema.json b/dotcom-rendering/src/model/article-schema.json
@@ -841,6 +841,9 @@
                     "type": "string",
                     "const": "model.dotcomrendering.pageElements.AudioBlockElement"
                 },
+                "id": {
+                    "type": "string"
+                },
                 "elementId": {
                     "type": "string"
                 },

diff --git a/dotcom-rendering/src/model/block-schema.json b/dotcom-rendering/src/model/block-schema.json
@@ -428,6 +428,9 @@
                     "type": "string",
                     "const": "model.dotcomrendering.pageElements.AudioBlockElement"
                 },
+                "id": {
+                    "type": "string"
+                },
                 "elementId": {
                     "type": "string"
                 },

diff --git a/dotcom-rendering/src/types/content.ts b/dotcom-rendering/src/types/content.ts
@@ -45,6 +45,7 @@ export interface AudioAtomBlockElement {
 
 interface AudioBlockElement {
 	_type: 'model.dotcomrendering.pageElements.AudioBlockElement';
+	id?: string;
 	elementId: string;
 	assets: AudioAsset[];
 }