This repository has been archived by the owner on Jul 12, 2023. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this change?
This PR adds 2 accessibility improvements
FocusLock
, improving keyboard access to the filtersWhy?
We don't need to lock focus on these filters because it's logical to tab through them and the previous package we were using was causing focus to stop on two hidden divs, which would be confusing for people who use screen readers
Focus before
It's hard to see from the recording but focus is landing on two hidden divs when tabbing through the menus
Screen.Recording.2022-01-18.at.16.12.49.mov
Focus after
without.mov
Wait, look, it's James!
@jamesgorrie - you left but we never stopped staring at your sunflower avatar