This repository has been archived by the owner on Jul 12, 2023. It is now read-only.
Fix svg button issues #354
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
liywjl
requested review from
markjamesbutler,
gtrufitt,
paulmr,
amyhughes and
jennygrahamjones
nitro-marky
approved these changes
Oct 28, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this change?
Fixes
show more commentssvg button (not displaying on chrome and taking up too big on firfore)Also fixes alignment issues of the upvote svg by using flexbox rather than margin guessing
Also adds a story to display
show more repliesto catch issue in visual regressionBefore
After
Why?
SVGs looked broken on Chrome and Firefox
Link to supporting Trello card
https://trello.com/c/qvm4skV0/2120-discussion-render-svg-issues