Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove old TLS version and add new one #26

Merged
merged 1 commit into from
Dec 14, 2021
Merged

Remove old TLS version and add new one #26

merged 1 commit into from
Dec 14, 2021

Conversation

mchv
Copy link
Member

@mchv mchv commented Dec 13, 2021

What does this change?

TLSv1 and TLSv1.1 are insecure and have been deprecated from most browsers since a long time!
Ideally we should be only using TLSv1.3 but for compatibility reasons we can keep TLSv1.2

Screenshot 2021-12-13 at 17 05 10

Screenshot 2021-12-13 at 17 06 32

davidfurey
davidfurey approved these changes Dec 13, 2021
View reviewed changes
Copy link
Member

@davidfurey davidfurey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@akash1810
Copy link
Member

This'll need a new release. Unfortunately this is currently manual:

  1. Create a new tarball by running create-release.sh
  2. Create a new release on GitHub, uploading the tarball from 1
  3. Update the homebrew formula, setting version, url and sha256 (example)

@mchv
Copy link
Member Author

mchv commented Dec 14, 2021

@akash1810 thanks I will try to do it

@mchv mchv merged commit a7ff8c1 into main Dec 14, 2021
@mchv mchv deleted the mc-remove-deprecated-TLS-version branch December 14, 2021 09:19
mchv added a commit to guardian/homebrew-devtools that referenced this pull request Dec 14, 2021
@mchv
bump dev-nginx to 1.4.0
8fd7334 
As per https://github.com/guardian/dev-nginx/releases/tag/v1.4.0

see also guardian/dev-nginx#26
@mchv mchv mentioned this pull request Dec 14, 2021
Merged
@mchv
Copy link
Member Author

mchv commented Dec 14, 2021

@akash1810 Done see guardian/homebrew-devtools#76

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davidfurey davidfurey davidfurey approved these changes

@akash1810 akash1810 akash1810 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mchv @akash1810 @davidfurey